Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase 2 Trackers T21 + T22 + T23 (Mechanical Update in Outer Tracker + Sensors studies in Inner Tracker) #30927

Closed
wants to merge 124 commits into from

Conversation

ghugo83
Copy link
Contributor

@ghugo83 ghugo83 commented Jul 27, 2020

PR description:

This PR:

  • Introduces a Tracker baseline, called T21. It has a Phase 2 Outer Tracker with updated TBPS (changes in Layer 1 to facilitate IT insertion) and TEDD (update sensors Z inter-spacing in all TEDD).
  • Introduces T22, a Tracker based on T21, but with 50x50 um2 pixels everywhere in Inner Tracker.
  • Introduces T23, a Tracker based on T21, but with 3D sensors in TBPX L1 + TBPX L2 + TFPX R1.

T21:
tkLayout description: http://ghugo.web.cern.ch/ghugo/layouts/T21/OT800_IT615/layoutpixel.html
Geometry scenario: 2026D63.
Workflows: 294xx (no PU), 296xx (PU).

T22:
tkLayout description: http://ghugo.web.cern.ch/ghugo/layouts/T22/OT800_IT621/layoutpixel.html
Geometry scenario: 2026D64.
Workflows: 298xx (no PU), 300xx (PU).

T23:
tkLayout description: http://ghugo.web.cern.ch/ghugo/layouts/T23/OT800_IT700/layoutpixel.html
Geometry scenario: 2026D65.
Workflows: 302xx (no PU), 304xx (PU).

Following comparisons should be made:

Validate new Outer Tracker:

Compare T21 versus T20 (2026D63 versus 2026D56).
Should not expect any meaningful change in the tracking performance (maybe an extremely tiny degradation).

Inner Tracker sensors studies:

Now have a common base to compare different sensors options.
Only bricked pixels sensors option is missing (I included that geometry in another private branch).

25x100 -> 50x50:
Compare T22 (50x50, planar) versus T21 (25x100, planar) (2026D64 versus 2026D63).
An interesting fast sim estimate is available at:
25x100: http://ghugo.web.cern.ch/ghugo/layouts/T21/OT800_IT615/errorstracker.html
50x50: http://ghugo.web.cern.ch/ghugo/layouts/T22/OT800_IT621/errorstracker.html
With obviously, especially visible here at high pT, a significant degradation of pT and transverse impact parameter resolution, and an improvement of longitudinal impact parameter resolution. Of course less visible at low pT (multiple scattering).

planar -> 3D:
Compare T23 (3D) versus T21 (planar) (2026D65 versus 2026D63).
tkLayout track parameters code fully debugged and operational in the case of 3D sensors.
Though, would need to fix 3D local resolution parametrization used as input in tkLayout, to get meaningful fast sim results on that front as well.

PR validation:
Following was done for CMSSW validation:

  • Checked XMLs make sense from Tracker design point of view, in concordance with Mechanics.
  • Checked overlaps with Fireworks + Geant4 tools.
  • Checked workflow numbering.
  • Checked that workflows with D63, D64, D65 scenarios run smoothly with no extra error / warning.

FYI: @dpiparo @VinInn @cvuosalo @civanch @ianna @emiglior @skinnari @mmusich @jalimena @fabiocos @kpedro88

amkalsi and others added 30 commits May 28, 2020 15:24
…acilitate IT insertion) + In all TEDD, update dee sensors inter-spacing in Z. Add T22 Inner Tracker topology file.
…hen I added 3D sensors support, so update README now ;p.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ghugo83 ghugo83 restored the T21_T22_T23 branch July 30, 2020 09:09
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30927/17420

  • This PR adds an extra 304KB to repository

  • Found files with invalid states:

    • RecoMET/METFilters/python/BadPFMuonFilter_Dz_cfi.py:
    • HeterogeneousCore/SonicTriton/src/TritonUtils.cc:
    • HeterogeneousCore/SonicTriton/interface/TritonUtils.h:

@ghugo83
Copy link
Contributor Author

ghugo83 commented Jul 30, 2020

Reopened it at #30976 .
Sorry, but for some mysterious reason, the github comparison is being made here to the 'old' master branch from yesterday.

@alja
Copy link
Contributor

alja commented Jul 30, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2020

The tests are being triggered in jenkins.

@kpedro88
Copy link
Contributor

please close

@kpedro88
Copy link
Contributor

@smuzaffar @mrodozov can we prevent the bot from starting tests for closed PRs?

@smuzaffar
Copy link
Contributor

sure, bot should not test closed PR. I will fix it.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5afca5e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57c0a5/8432/summary.html
CMSSW: CMSSW_11_2_X_2020-07-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57c0a5/8432/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525390
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

move to #31673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment