HCAL MC: adding pulse shape 208 for signal reconstruction

[yihui-lai]

PR description:

• added pulse Shape 208, it is a resulting pulse from phase scan of MC Digi of Shape 206.

Link to related slides:

• https://indico.cern.ch/event/936151/#110-mc-hbhe-signal-shape-time
• https://indico.cern.ch/event/935592/#3-mc-hbhe-signal-shape-time-sc
• https://indico.cern.ch/event/943042/#5-mc-hbhe-signal-shape-time-sc
• https://indico.cern.ch/event/943042/#6-2021-mcreco-with-pulse-shape

PR validation:

Code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31014/17489

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31014/17489/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31014/17489/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31014/17493

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @yihui-lai for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos
SimCalorimetry/HcalSimAlgos

@civanch, @christopheralanwest, @tocheng, @cmsbuild, @mdhildreth, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mariadalfonso, @rovere, @abdoulline, @mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[pohsun]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-31-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8487/console Started: 2020/08/01 08:00

[abdoulline]

@yihui-lai could you edit the PR title this (more self-explanatory) way: "HCAL MC: adding pulse shape 208 for signal reconstruction"?

[cmsbuild]

+1
Tested at: 8f13109
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fef92/8487/summary.html
CMSSW: CMSSW_11_2_X_2020-07-31-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fef92/8487/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525448
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525400
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[christopheralanwest]

Is an update to HcalMCParams and/or HcalRecoParams planned to enable this change?

[civanch]

+1

[abdoulline]

@christopheralanwest yes, HcalRecoParams for Run3 MC, once this PR is merged.
But HCAL DPG decided to decouple it from other Run3 ongoing conditions updates in your #30999

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1