migrate from run2_miniAOD_devel to run2_miniAOD_UL for miniAOD setup UL workflows

[slava77]

This PR switches from a generic run2_miniAOD_devel modifier to the run2 UL re-miniAOD target run2_miniAOD_UL.

Additionally, RecoEgamma/EgammaTools/python/egammaObjectModificationsInMiniAOD_cff.py now enables the electron/photon scales and smearing (something missed in #30199)

Tests

• regular setup of re-miniAOD workflows runs and produces differences in expected places compared to the baseline (which is equivalent to the original UL miniAOD)
  • This is mostly an integration test with a bit conceptual validation; the comparison here was done at a bit earlier step in CMSSW_10_6_X_2020-07-29-2300
• (non-ideal) identity test is done to compare UL reminiAOD made in CMSSW_11_2_X_2020-07-29-1100 (which has all bugfixes and UL-specific settings enabled with run2_miniAOD_UL) with CMSSW_10_6_X_2020-08-05-1100 + this PR using 112X GT. This test is done only for data wf 136.88811 (reprocessing of 2018).
  • Reco comparisons are available in https://slava77sk.web.cern.ch/slava77sk/reco/relvaldiffs/CMSSW_10_6_X_2020-08-05-1100-sign1107/ {red is 106X with GT from 112X and black is 112X} (I looked mostly at 136.88811 in reco comparisons all_* directory; the dqm plots in dqm_* are available as well, but apparently some plot formats or selections have changed)
  • detailed comparison shows mostly expected unchanged results (e.g. no differences in packedCandidates, except for puppi-related noLepton weights) with some differences
    • many small differences are apparently related to the minor/acceptable changes and bugfixes introduced during puppi migration to RECO ( PUPPI MET in RECO #29254 )
  • differences in taus have several sources:
    • againstElectronDeadECAL in taus was not properly updated in master ==> bugfix in Fix to enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs #31047
    • againstElectron*MVA6 were not backported from after Update tau anti electron discriminators in RECO and MiniAOD #27465
    • I'm guessing that the small differences in deepTau discriminants are due to the changes in the PUPPI variables (esp the puppiWeightNoLep )
    • minor changes in basic discriminants are expected from New Tau ID data format #28417 (not backported), e.g. in byCombinedIsolationDeltaBetaCorrRaw3Hits have small differences beyond numerical precision
  • differences in slimmedMETsNoHF UnclusteredEn: see CandPtrProjector unclustered candidate matching for MET NoHF (bug in miniAOD MET NoHF) #31071 , apparently the master version is incorrect
  • very small differences in slimmedMETs UnclusteredEn (one event out of 4K tested), apparently due to different way of matching candidates by dR in 106X vs directly by Ptr (part of PUPPI MET in RECO #29254 not backported to 106X)

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_6_X.

It involves the following packages:

CommonTools/PileupAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoCTPPS/ProtonReconstruction
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoJets/JetProducers
RecoMET/METProducers
RecoTauTag/Configuration

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @yslai, @jainshilpi, @hatakeyamak, @rappoccio, @lgray, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @varuns23, @jdolen, @ferencek, @forthommel, @Sam-Harper, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @jan-kaspar, @JyothsnaKomaragiri, @mverzett, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-08-05-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8602/console Started: 2020/08/06 02:57

[cmsbuild]

+1
Tested at: bd0bca6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7daf26/8602/summary.html
CMSSW: CMSSW_10_6_X_2020-08-05-2300
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7daf26/8602/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 491 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214618
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214281
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[slava77]

Reco comparison results: 491 differences found in the comparisons
These are all in the (only) UL re-miniAOD workflow 136.88811, which is still set to effectively do just redo the standard UL miniAOD in the baseline.

Also, in bin-by-bin comparisons we can see

• the expected increase in the lostTracks in more detail https://tinyurl.com/y49fs2nv (this does not show up in the reco comparisons due to issues with packed candidates format display in plain FWLite by the reco validation script)

[slava77]

+1

for #31072 bd0bca6

• changes in the jenkins tests are as expected only in the modified UL re-miniAOD workflow 136.88811

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1