Remove or make const few PFCluster obsolete data members

[fwyzard]

PR description:

Clean up the PFCluster class removing obsolete data member and methods, and making some static data members constexpr.

PR validation:

Code compiles after git cms-checkdeps -a.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31149/17771

• This PR adds an extra 24KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8770/console Started: 2020/08/15 14:18

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DataFormats/ParticleFlowReco

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@cbernet, @lgray, @rovere, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 515b760
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c67fd/8770/summary.html
CMSSW: CMSSW_11_2_X_2020-08-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c67fd/8770/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2608246
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2608186
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• Removed methods and class members are indeed obsolete and not used anywhere else in CMSSW
• The comment in the description field of Cleanup of the PFTrack class #31151 implies that PF coveners (@hatakeyamak @bendavid) are aware of this cleaning and agree with it
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[perrotta]

Rethinhing at it (somehow late...): shouldn't a new class version be defined, since the interface has changed?
@fwyzard

[fwyzard]

I thought about that, run edmCheckClassVersion, and nothing came up.
I guess it's because the transient or static members do not count ?

[perrotta]

Indeed: "Should the class be modified by adding, removing, renaming, or changing the type of any non-transient non-static data member, the new classes_def.xml file might look like [...]" (from https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts#Class_versioning)
Thank you for having checked, Andrea