new-aperture-parametrization-CTPPS

[ChrisMisan]

PR description:

New parametrization of LHC aperture effects in PPS detectors as approved by POG meeting 25.08.2020: https://indico.cern.ch/event/948858/contributions/3988080/attachments/2090986/3513523/New%20parametrization%20of%20LHC%20aperture%20effects%20in%20PPS%20detectors.pdf

PR is going to improve aperture cuts quality in direct simulation by replacing single line parametrization with two segment lines.

PR validation:

https://indico.cern.ch/event/948858/contributions/3988080/attachments/2090986/3513523/New%20parametrization%20of%20LHC%20aperture%20effects%20in%20PPS%20detectors.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31250/17910

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/CTPPS/plugins/CTPPSDirectProtonSimulation.cc modified in PR(s): Port CTPPS to DD4hep #31240, [PPS] Timing detector preparation for 2021 conditions #30252

[cmsbuild]

A new Pull Request was created by @ChrisFlam3 for master.

It involves the following packages:

Validation/CTPPS

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-26-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8946/console Started: 2020/08/27 11:14

[cmsbuild]

+1
Tested at: 35c341c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d14276/8946/summary.html
CMSSW: CMSSW_11_2_X_2020-08-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d14276/8946/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jan-kaspar]

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons

Perhaps it is worth noticing that no difference has been found since the matrix tests don't include the "direct" simulation which is updated by this PR.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1