Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily reject 16-partition GE2/1 clusters in the EMTF #31409

Merged
merged 16 commits into from Sep 11, 2020
Merged

Temporarily reject 16-partition GE2/1 clusters in the EMTF #31409

merged 16 commits into from Sep 11, 2020

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Sep 9, 2020

PR description:

Temporarily reject 16-partition GE2/1 clusters, because the EMTF is not yet adapted to handle these objects.

Follow-up of #31268 (to be merged first). The relevant commit for this PR is bef7957.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @jiafulow @eyigitba @abrinke1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31409/18270

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

+1
Tested at: bef7957
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2e423/9227/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2e423/9227/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 9, 2020

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 9, 2020

@dildick why not just update #31268 with this change?

@dildick
Copy link
Contributor Author

dildick commented Sep 9, 2020

I did not want to interfere with EMTF development, so I suggested to EMTF folks what needed to be done on their end. Then Jia Fu proposed that I make the change myself, so I made a new pull request.

At this point #31268 is almost signed off; I just need Vladimir's signature.

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 9, 2020

+1

@civanch
Copy link
Contributor

civanch commented Sep 9, 2020

+1

@kpedro88
Copy link
Contributor

+upgrade

@bsunanda
Copy link
Contributor

@silviodonato Could this PR be merged quickly?

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit fc40071 into cms-sw:master Sep 11, 2020
@silviodonato
Copy link
Contributor

@rekovic

@dildick dildick deleted the from-CMSSW_11_2_X_2020-09-08-2300-reject-16-ge21-pads branch September 13, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants