make multilinks transient

[jpata]

PR description:

Attempt at fixing the IB failures arising after merging #31295. Multilinks are not used outside of PFBlockAlgo, hence there doesn't seem to be a need to save them. Making them transient seems to fix the issue, but to be validated.

PR validation:

Compiles, workflow 134.807 completes successfully.

attn @hatakeyamak

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31485/18407

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

DataFormats/ParticleFlowReco

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@cbernet, @lgray, @rovere, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test workflow 134.807, 134.808, 134.907, 134.908, 136.727, 136.728, 136.8391

(based on #31295 (comment))

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 136.727,134.908,134.907,134.808,134.807,136.8391,136.728
• CMSSW_11_2_X_2020-09-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9378/console Started: 2020/09/16 15:22

[cmsbuild]

+1
Tested at: cfbe5bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d18eb9/9378/summary.html
CMSSW: CMSSW_11_2_X_2020-09-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d18eb9/9378/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d18eb9/134.807_RunDoubleEGPrpt2015C+RunDoubleEGPrpt2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d18eb9/134.808_RunSingleMuPrpt2015C+RunSingleMuPrpt2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d18eb9/134.907_RunDoubleEGPrpt2015D+RunDoubleEGPrpt2015D+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d18eb9/134.908_RunSingleMuPrpt2015D+RunSingleMuPrpt2015D+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d18eb9/136.8391_RunExpressPhy2017F+RunExpressPhy2017F+HLTDR2_2017+RECODR2_2017reHLTSiPixelCalZeroBias_Prompt+HARVEST2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2620306
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2620278
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jpata]

Seems like this fixes the crash, at least.

[hatakeyamak]

Thx. And, of course no change in RECO output. So, it's good to go?

[jpata]

+reconstruction

• make reco::PFBlockElement::multilinks_ transient, as it's used only internally in PFBlockAlgo
• no changes to reco validation plots, reMINIAOD workflows 136.xxx run successfully now
• should fix the IB crash observed after Reorganization of kdtrees for PFBlockAlgo and optimize track-hcal links #31295, reported in Reorganization of kdtrees for PFBlockAlgo and optimize track-hcal links #31295 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1