Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[102X] NanoAOD: add flag to keep all PS weights #31620

Merged

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Sep 30, 2020

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #31276 to fix nanoAOD workflows crashing in 102X because of cms-nanoAOD#538

@agrohsje

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swertz (Sébastien Wertz) for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: a33203d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c7056/9658/summary.html
CMSSW: CMSSW_10_2_X_2020-09-29-2300
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c7056/9658/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007544
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007351
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.434 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 0.434 KiB Physics/NanoAODDQM
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Sep 30, 2020

+xpog

backport inline with changes in master and 10_6

This is needed to follow up on these failing samples
https://cms-pdmv.cern.ch/mcm/requests?prepid=HIG-RunIIFall17NanoAODv7-0*&dataset_name=*NMSSM_XToYHTo4b_MX-*_TuneCP5_13TeV-madgraph-pythia8*&page=0&shown=4294967423
The other changes in the PR would not affect the content as they are protected by the keepAllPSWeights = cms.bool(False)

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit bb74f9c into cms-sw:CMSSW_10_2_X Oct 2, 2020
@santocch
Copy link

santocch commented Oct 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants