Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of "DisplacedSUSY" relvals for TRK and EXO validation of displaced tracks, for Run 3 and Phase 2 #31692

Merged
merged 2 commits into from Oct 9, 2020

Conversation

jalimena
Copy link
Contributor

@jalimena jalimena commented Oct 7, 2020

PR description:

This PR updates the "DisplacedSUSY" relvals, for tracking and exotica validation of displaced tracks.

The DisplacedSUSY process simulates the pair-production of long-lived stops that each decay through an RPV vertex to a lepton (e, mu, or tau with 1/3 probability each) and a b-quark. This sample thus produces displaced leptons.

In this PR, there are a few changes and additions:

  • The stop mass was updated from 300 GeV to 800 GeV, in order to use a mass that has not yet been excluded. The stop lifetime was updated from 1000mm to 500mm in order to increase the tracker acceptance for displaced tracks. (The "DisplacedSUSY_stopToB_M_300_1000mm_13" gen fragment and WFs were removed and replaced by "DisplacedSUSY_stopToB_M_800_500mm_13" ones.)
  • In addition to the 13 TeV WFs, 14 TeV WFs were added, in order to validate changes for Run 3 and Phase 2.

This sample was agreed upon in https://its.cern.ch/jira/browse/PDMVRELVALS-96.

I believe the most interesting WFs will be:

  • 23324.0 (2026D49, 14 TeV, no PU)
  • 23524.0 (2026D49, 14 TeV, PU)
  • 11724.0 (2021, 14 TeV, no PU)
  • 11924.0 (2021, 14 TeV, PU)

PR validation:

This PR passes the basic unit tests and code quality checks. I have also successfully tested WF 23285.0 locally.

if this PR is a backport please specify the original PR and why you need to backport that PR:

not a backport

FYI @mtosi @vmariani @elusiani @Fernance @lowette @nsaoulid @kdipetri @mcitron @jandrea @blochd @mmasciov @chayanit @srappocc

…opToB_M_800_500mm_13/14 gen fragments and in WFs
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31692/18840

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@@ -1144,7 +1144,8 @@ def __init__(self, howMuch, dataset):
('HSCPstop_M_200_TuneCUETP8M1_13TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'HSCPstop_M_200_13')),
('RSGravitonToGammaGamma_kMpl01_M_3000_TuneCUETP8M1_13TeV_pythia8_cfi', UpgradeFragment(Kby(9,50),'RSGravitonToGaGa_13')),
('WprimeToENu_M-2000_TuneCUETP8M1_13TeV-pythia8_cff', UpgradeFragment(Kby(9,50),'WpToENu_M-2000_13')),
('DisplacedSUSY_stopToBottom_M_300_1000mm_TuneCUETP8M1_13TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'DisplacedSUSY_stopToB_M_300_1000mm_13')),
('DisplacedSUSY_stopToBottom_M_800_500mm_TuneCP5_13TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'DisplacedSUSY_stopToB_M_800_500mm_13')),
('DisplacedSUSY_stopToBottom_M_800_500mm_TuneCP5_14TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'DisplacedSUSY_stopToB_M_800_500mm_14')),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not ruin the order of existing workflow IDs, please move the new one to the bottom. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, should be done now

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31692/18842

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

Pull request #31692 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

@chayanit
Copy link

chayanit commented Oct 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

+1
Tested at: 011392c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc84d1/9771/summary.html
CMSSW: CMSSW_11_2_X_2020-10-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

Comparison job queued.

@chayanit
Copy link

chayanit commented Oct 8, 2020

To @agrohsje, would you agree the replacement of "DisplacedSUSY_stopToB_M_300_1000mm_13" gen fragment with "DisplacedSUSY_stopToB_M_800_500mm_13"? or do you like to have a new fragment instead?

@agrohsje
Copy link

agrohsje commented Oct 8, 2020

Hi @chayanit . No objections from my side.

+generators

@chayanit
Copy link

chayanit commented Oct 8, 2020

+1

seems the bot can't recognise your signature above @agrohsje

@agrohsje
Copy link

agrohsje commented Oct 8, 2020

+generators

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 8, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 9, 2020

+1

@cmsbuild cmsbuild merged commit a03f63d into cms-sw:master Oct 9, 2020
@smuzaffar
Copy link
Contributor

@jalimena , looks like the new data set /RelValDisplacedSUSY_stopToBottom_M_800_500mm_13/CMSSW_10_6_0-106X_mcRun2_asymptotic_v3-v1/GEN-SIM is not yet available ( DAS does not know about it ). This is causing workflow 1355 to fail , do we have this data set produced?

[a]
dasgoclient --limit 0 --query 'file dataset=/RelValDisplacedSUSY_stopToBottom_M_800_500mm_13/CMSSW_10_6_0-106X_mcRun2_asymptotic_v3-v1/GEN-SIM'

@jalimena
Copy link
Contributor Author

hi @smuzaffar , no, I don't have this dataset produced yet. Should I generate it privately? Have I made a mistake in the PR?

@@ -3220,7 +3219,7 @@ def gen2021HiMix(fragment,howMuch):
defaultDataSets.update(puDataSets)

# sometimes v1 won't be used - override it here - the dictionary key is gen fragment + '_' + geometry
versionOverrides={'BuMixing_BMuonFilter_forSTEAM_13TeV_TuneCUETP8M1_2017':'2','HSCPstop_M_200_TuneCUETP8M1_13TeV_pythia8_2017':'2','RSGravitonToGammaGamma_kMpl01_M_3000_TuneCUETP8M1_13TeV_pythia8_2017':'2','WprimeToENu_M-2000_TuneCUETP8M1_13TeV-pythia8_2017':'2','DisplacedSUSY_stopToBottom_M_300_1000mm_TuneCUETP8M1_13TeV_pythia8_2017':'2','TenE_E_0_200_pythia8_2017':'2','TenE_E_0_200_pythia8_2017PU':'2', 'TenTau_E_15_500_pythia8_2018':'2','PhotonJet_Pt_10_13TeV_TuneCUETP8M1_2018':'2','Wjet_Pt_80_120_13TeV_TuneCUETP8M1_2018':'2'}
versionOverrides={'BuMixing_BMuonFilter_forSTEAM_13TeV_TuneCUETP8M1_2017':'2','HSCPstop_M_200_TuneCUETP8M1_13TeV_pythia8_2017':'2','RSGravitonToGammaGamma_kMpl01_M_3000_TuneCUETP8M1_13TeV_pythia8_2017':'2','WprimeToENu_M-2000_TuneCUETP8M1_13TeV-pythia8_2017':'2','DisplacedSUSY_stopToBottom_M_800_500mm_TuneCP5_13TeV_pythia8_2017':'2','TenE_E_0_200_pythia8_2017':'2','TenE_E_0_200_pythia8_2017PU':'2', 'TenTau_E_15_500_pythia8_2018':'2','PhotonJet_Pt_10_13TeV_TuneCUETP8M1_2018':'2','Wjet_Pt_80_120_13TeV_TuneCUETP8M1_2018':'2'}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not necessary to change I think @jalimena

@@ -602,8 +602,7 @@ def gen2021hiprod(fragment,howMuch):
steps['HSCPstop_M_200_13']=gen2015('HSCPstop_M_200_TuneCUETP8M1_13TeV_pythia8_cff',Kby(9,100))
steps['RSGravitonToGaGa_13']=gen2015('RSGravitonToGammaGamma_kMpl01_M_3000_TuneCUETP8M1_13TeV_pythia8_cfi',Kby(9,100))
steps['WpToENu_M-2000_13']=gen2015('WprimeToENu_M-2000_TuneCUETP8M1_13TeV-pythia8_cff',Kby(9,100))
steps['DisplacedSUSY_stopToBottom_M_300_1000mm_13']=gen2015('DisplacedSUSY_stopToBottom_M_300_1000mm_TuneCUETP8M1_13TeV_pythia8_cff',Kby(9,100))

steps['DisplacedSUSY_stopToBottom_M_800_500mm_13']=gen2015('DisplacedSUSY_stopToBottom_M_800_500mm_TuneCP5_13TeV_pythia8_cff',Kby(9,100))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we keep M300 and 1000mm for 2015 (&2016) conditions here

@@ -780,7 +779,7 @@ def identitySim(wf):
steps['HSCPstop_M_200_13INPUT']={'INPUT':InputInfo(dataSet='/RelValHSCPstop_M_200_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}
steps['RSGravitonToGaGa_13INPUT']={'INPUT':InputInfo(dataSet='/RelValRSGravitonToGaGa_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}
steps['WpToENu_M-2000_13INPUT']={'INPUT':InputInfo(dataSet='/RelValWpToENu_M-2000_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}
steps['DisplacedSUSY_stopToBottom_M_300_1000mm_13INPUT']={'INPUT':InputInfo(dataSet='/RelValDisplacedSUSY_stopToBottom_M_300_1000mm_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}
steps['DisplacedSUSY_stopToBottom_M_800_500mm_13INPUT']={'INPUT':InputInfo(dataSet='/RelValDisplacedSUSY_stopToBottom_M_800_500mm_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep M300 and 1000mm for 2015 (&2016) conditions here

@@ -1144,7 +1144,7 @@ def __init__(self, howMuch, dataset):
('HSCPstop_M_200_TuneCUETP8M1_13TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'HSCPstop_M_200_13')),
('RSGravitonToGammaGamma_kMpl01_M_3000_TuneCUETP8M1_13TeV_pythia8_cfi', UpgradeFragment(Kby(9,50),'RSGravitonToGaGa_13')),
('WprimeToENu_M-2000_TuneCUETP8M1_13TeV-pythia8_cff', UpgradeFragment(Kby(9,50),'WpToENu_M-2000_13')),
('DisplacedSUSY_stopToBottom_M_300_1000mm_TuneCUETP8M1_13TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'DisplacedSUSY_stopToB_M_300_1000mm_13')),
('DisplacedSUSY_stopToBottom_M_800_500mm_TuneCP5_13TeV_pythia8_cff', UpgradeFragment(Kby(9,50),'DisplacedSUSY_stopToB_M_800_500mm_13')),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to update only upgrade workflows and leave standard workflow as it is

@@ -660,7 +660,7 @@
workflows[1352] = ['', ['HSCPstop_M_200_13','DIGIUP15','RECOUP15','HARVESTUP15']]
workflows[1353] = ['', ['RSGravitonToGaGa_13','DIGIUP15','RECOUP15','HARVESTUP15']]
workflows[1354] = ['', ['WpToENu_M-2000_13','DIGIUP15','RECOUP15','HARVESTUP15']]
workflows[1355] = ['', ['DisplacedSUSY_stopToBottom_M_300_1000mm_13','DIGIUP15','RECOUP15','HARVESTUP15']]
workflows[1355] = ['', ['DisplacedSUSY_stopToBottom_M_800_500mm_13','DIGIUP15','RECOUP15','HARVESTUP15']]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we update only upgrade workflows and leave standard workflow as the old sample since we don't produce this 1355 anymore

@chayanit
Copy link

chayanit commented Oct 13, 2020

Hi @jalimena , may I propose we update only "upgrade" workflow in upgradeWorkflowComponents.py and leave everything in relval_standard as it is? We actually do not run 2015 workflow anymore. So then we may need to have the old fragment back in Configuration/Genproduction package? Sorry for this mess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants