Fix HGCalValidation for different Tracksers collections

[ebrondol]

PR description:

Currently the makeHGCalValidationPlots.py does not produce different plots for different Tracksters collections in input, but it takes only the first folder given in input [1].

This is clearly visible in the HGCal release validation looking, for example, at the comparison between CMSSW_11_2_0_pre6_ROOT622_vs_CMSSW_11_2_0_pre6 the plots produced for "Electromagnetic multiclusters" and "Hadronic multiclusters" are identical. For example the NumberofMultiClusters in Zprime [here and here].

With this PR, the problem is solved by replacing the name of the folder in DQMData/Run 1/HGCAL/Run summary/HGCalValidator in the DQM file.with the correct collection name.

[1] https://github.com/cms-sw/cmssw/blob/master/Validation/RecoTrack/python/plotting/plotting.py#L2902-L2912

PR validation:

These changes are not impacting any workflows.
Additional check were performed on the HGCalValidation output and can be found here:
http://ebrondol.web.cern.ch/ebrondol/HGCal/fixHGCalValidation_collections/20201005/

Informing @rovere and @apsallid

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31695/18848

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @ebrondol (Erica Brondolin) for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @deguio, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9775/console Started: 2020/10/07 17:02

[cmsbuild]

+1
Tested at: 6849d21
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-029759/9775/summary.html
CMSSW: CMSSW_11_2_X_2020-10-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-029759/9775/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542194
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1