Fixed Non Planar Trapezoids in Scenario 2021

[slomeo]

PR description:

This PR has been triggered by what @ianna and @etcherniaev wrote in the PR #31824. Side X of YB2_w1_m5 in muonYoke.xml was not planar for solid.

PR validation:

1. validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"
   The attached picture shows, after this PR, no Muon overlaps.

2. validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py >& overlaps.out &"
   Muon's volumes are not present in the overlaps.out file.

3. validation by runTheMatrix.py -l 25202.1 :

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Sat Oct 17 08:48:39 2020-date Sat Oct 17 08:27:15 2020; exit: 0 0 0 0 1 1 1 1 tests passed, 0 0 0 0 failed

4. Validation by @etcherniaev ' s routine TrapParamsAdjustment

before this PR: Max shift in x : 0.02793193334628086

after this PR: Max shift in x : 0

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31837/19166

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Geometry/python/dict2021Geometry.py modified in PR(s): Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832
  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770, [DD4hep] Update to DD4hep master of 16.10.2020 #31821, Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832
  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021ZeroMaterial.xml modified in PR(s): Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832
  • File Geometry/CMSCommonData/python/cmsExtendedGeometry2021XML_cfi.py modified in PR(s): Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832
  • File Geometry/CMSCommonData/python/cmsExtendedGeometry2021ZeroMaterialXML_cfi.py modified in PR(s): Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832

[cmsbuild]

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @fabiocos, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slomeo]

please @civanch, @cvuosalo, @ianna, @kpedro88, @bsunanda, @etcherniaev perform a "please test"

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10047/console Started: 2020/10/17 15:14

[bsunanda]

@slomeo You need not update the dictionary or the scenarios. Can you please withdraw them. I shall update the scenario once all the changes are done

[slomeo]

@bsunanda : how can I do? I have to restore all the 2021 scenarios and leaving the changes only for muonYoke.xml. Is it so?

[cmsbuild]

+1
Tested at: af95e28
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b369/10047/summary.html
CMSSW: CMSSW_11_2_X_2020-10-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[bsunanda]

@slomeo Yes please copy the ones from $CMSSW_RELEASE_BASE and only keep your new xml file. Then update the PR with that.

[slomeo]

@bsunanda : it's better close this PR and then I'll start in a clean IB with only one change

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b369/10047/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543726
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files