New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New background model for GEM digitizer #3185
New background model for GEM digitizer #3185
Conversation
A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC. New background model for GEM digitizer It involves the following packages: Geometry/CaloTopology @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
@@ -95,7 +96,28 @@ | |||
int units = (int)(dPhiTableHF[k]/fiveDegInRad+0.5); | |||
unitPhiHF.push_back(units); | |||
} | |||
std::cout << "Constants in HcalTopology " << firstHBRing_ << ":" << lastHBRing_ << " " << firstHERing_ << ":" << lastHERing_ << ":" << firstHEDoublePhiRing_ << ":" << firstHEQuadPhiRing_ << ":" << firstHETripleDepthRing_ << " " << firstHFRing_ << ":" << lastHFRing_ << ":" << firstHFQuadPhiRing_ << " " << firstHORing_ << ":" << lastHORing_ << " " << maxDepthHB_ << ":" << maxDepthHE_ << " " << nEtaHB_ << ":" << nEtaHE_ << " " << etaHE2HF_ << ":" << etaHF2HE_ << std::endl; | |||
int nEta = hcons_->getNEta(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dildick - I'm not sure you do want to modify HcalTopolgy for GEM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dildick and @ianna - It looks like these are the exact same things that @bsunanda committed and were merged yesterday and not things that Sven added himself. Maybe you had merged his commit and not rebased. I'm working on the calotower PR right now. Then I'll try the merge and see if there are conflicts.
New background model for GEM digitizer
No description provided.