Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New background model for GEM digitizer #3185

Merged
merged 5 commits into from Apr 4, 2014
Merged

New background model for GEM digitizer #3185

merged 5 commits into from Apr 4, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 3, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

New background model for GEM digitizer

It involves the following packages:

Geometry/CaloTopology
SimMuon/GEMDigitizer

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -95,7 +96,28 @@
int units = (int)(dPhiTableHF[k]/fiveDegInRad+0.5);
unitPhiHF.push_back(units);
}
std::cout << "Constants in HcalTopology " << firstHBRing_ << ":" << lastHBRing_ << " " << firstHERing_ << ":" << lastHERing_ << ":" << firstHEDoublePhiRing_ << ":" << firstHEQuadPhiRing_ << ":" << firstHETripleDepthRing_ << " " << firstHFRing_ << ":" << lastHFRing_ << ":" << firstHFQuadPhiRing_ << " " << firstHORing_ << ":" << lastHORing_ << " " << maxDepthHB_ << ":" << maxDepthHE_ << " " << nEtaHB_ << ":" << nEtaHE_ << " " << etaHE2HF_ << ":" << etaHF2HE_ << std::endl;
int nEta = hcons_->getNEta();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dildick - I'm not sure you do want to modify HcalTopolgy for GEM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dildick and @ianna - It looks like these are the exact same things that @bsunanda committed and were merged yesterday and not things that Sven added himself. Maybe you had merged his commit and not rebased. I'm working on the calotower PR right now. Then I'll try the merge and see if there are conflicts.

@mark-grimes
Copy link

merge

I also don't see any difference in HcalTopology.cc after merging, so it's a peculiarity in how the request was based. Tested together with #3202 and #3214, see the notes on #3214 for a log of tests.

cmsbuild added a commit that referenced this pull request Apr 4, 2014
@cmsbuild cmsbuild merged commit d97829c into cms-sw:CMSSW_6_2_X_SLHC Apr 4, 2014
@dildick dildick deleted the New-bkg-model-GEM-digitizer branch April 8, 2014 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants