Clean BuildFiles in EventFilter

[guitargeek]

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #31830).

This BuildFile cleaning was non-trivial because the affected packages included files from different plugins directories. These illegal includes had to be fixed for the automatic BuildFile cleaning to work out.

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31898/19307

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQM/L1TMonitor
EventFilter/CSCTFRawToDigi
EventFilter/L1TXRawToDigi

@benkrikler, @kmaeshima, @andrius-k, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-21-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10203/console Started: 2020/10/22 14:18

[cmsbuild]

+1
Tested at: a576efc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-651cc2/10203/summary.html
CMSSW: CMSSW_11_2_X_2020-10-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-651cc2/10203/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544110
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544081
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

+1

[guitargeek]

Hi @rekovic, is this change okay for you? Some files were moved around to avoid illegal includes from the plugins directory.

[silviodonato]

@cms-sw/l1-l2 do you have any comments?
Please let us know if you prefer either to move the header files to interface (ie. merge thsi PR) or to remove the dependencies from EventFilter/L1TXRawToDigi/plugins/*h in DQM/L1TMonitor/src/L1TStage2CaloLayer1.cc

[guitargeek]

Actually the problem is not only the dependency in DQM/L1TMonitor/src/L1TStage2CaloLayer1.cc, but also the dependency in EventFilter/L1TXRawToDigi/test.

[silviodonato]

@cms-sw/l1-l2 please review/sign

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1