Add PDF sets to nano, prioritize by order in LHE file

[kdlong]

PR description:

Switch loops in nanoaod producer so that PDF sets are prioritized
by the order in the file, not the order in the config. Now chooses the
first PDF set in the file which is part of the list of "approved" sets
in the config. Also adds additional sets to this list

PR validation:

Checked that the logic works in a few files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31946/19392

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc modified in PR(s): Workaround for NanoAOD LHE weights in newer MadGraph #31680, Store EW parameter weights in NanoAOD of W mass samples #31939

[cmsbuild]

A new Pull Request was created by @kdlong (Kenneth Long) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-26-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10306/console Started: 2020/10/27 08:40

[agrohsje]

Hi Kenneth.
Two comments from my side:
1.) Should we include 90900 as used here: https://github.com/cms-sw/genproductions/pull/2729/files ?
2.) Wouldn't it make sense to have the positive PDF's first in the list. I assume older request like the top ones won't have 325300, but 306000. Searches might have both and prefer to use 325300.
Cheers, Alexander.

[cmsbuild]

+1
Tested at: b4900fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f19dac/10306/summary.html
CMSSW: CMSSW_11_2_X_2020-10-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[mariadalfonso]

assign generators

[cmsbuild]

New categories assigned: generators

@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f19dac/10306/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544110
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544081
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cmsbuild]

+1
Tested at: 8dca3af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f19dac/10550/summary.html
CMSSW: CMSSW_11_2_X_2020-11-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f19dac/10550/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544144
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544115
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

+xpog

move the default PDF to NNPDF

1. size increase is documented here
   Add PDF sets to nano, prioritize by order in LHE file #31946 (comment)
2. validation plots are here
   Add PDF sets to nano, prioritize by order in LHE file #31946 (comment)

[santocch]

+1

[mariadalfonso]

@agrohsje
please review and sign

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

merge