[DD4hep] always close geometry #32000

ianna · 2020-11-02T10:09:46Z

PR description:

Fixes MagneticField/Engine unit tests
Requires [ROOT] Update root to latest 6.22 patches branch cmsdist#6353

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

ianna · 2020-11-02T10:09:59Z

please test with cms-sw/cmsdist#6353

cmsbuild · 2020-11-02T10:10:14Z

The code-checks are being triggered in jenkins.

ianna · 2020-11-02T10:10:35Z

@civanch - FYI

ianna · 2020-11-02T10:11:14Z

@mrodozov and @smuzaffar - FYI

cmsbuild · 2020-11-02T10:16:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32000/19512

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): PuppiMET with PUPPIv15 and UL17 PUID #31927

cmsbuild · 2020-11-02T10:16:37Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6353

CMSSW_11_2_X_2020-11-01-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10433/console Started: 2020/11/02 11:17

cmsbuild · 2020-11-02T10:16:39Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-11-02T21:36:30Z

-1

Tested at: 3dd8bb7

CMSSW: CMSSW_11_2_X_2020-11-01-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed229e/10433/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepDDSolid had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestUtilAlgos had ERRORS
---> test runtestPhysicsToolsNanoAOD had ERRORS
---> test runtestRecoTauTagRecoTau had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafExamples had ERRORS
---> test testRecoMETMETProducers had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test testTauEmbeddingProducers had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

136.793 step3

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step3_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.874 step3

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

158.01 step2

runTheMatrix-results/158.01_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD/step2_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

136.88811 step2

runTheMatrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step3_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECOMB+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

12434.0 step2

runTheMatrix-results/12434.0_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/step2_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA.log

11634.0 step3

runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/step3_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step3_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano/step3_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

28234.0 step3

runTheMatrix-results/28234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+D/bin/sh:/step3_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

23434.999 step3

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step3_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Mon Nov 2 22:19:30 2020-date Mon Nov 2 22:17:26 2020 s - exit: 35584
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-01-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Mon Nov 2 22:18:13 2020-date Mon Nov 2 22:17:28 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:23:43 2020-date Mon Nov 2 22:17:33 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:26:40 2020-date Mon Nov 2 22:17:38 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:26:58 2020-date Mon Nov 2 22:17:43 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:33:19 2020-date Mon Nov 2 22:17:44 2020 s - exit: 35584
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Mon Nov 2 22:20:18 2020-date Mon Nov 2 22:17:48 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:28:58 2020-date Mon Nov 2 22:17:51 2020 s - exit: 35584
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Mon Nov 2 22:20:24 2020-date Mon Nov 2 22:17:53 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:26:24 2020-date Mon Nov 2 22:17:55 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:28:28 2020-date Mon Nov 2 22:18:00 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:29:59 2020-date Mon Nov 2 22:18:04 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:28:45 2020-date Mon Nov 2 22:18:08 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:28:46 2020-date Mon Nov 2 22:18:09 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:25:59 2020-date Mon Nov 2 22:18:15 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:33:02 2020-date Mon Nov 2 22:18:18 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:26:34 2020-date Mon Nov 2 22:18:29 2020 s - exit: 35584
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Nov 2 22:30:57 2020-date Mon Nov 2 22:19:34 2020 s - exit: 35584

cmsbuild · 2020-11-02T21:36:35Z

Comparison job queued.

civanch · 2020-11-02T22:08:22Z

@ianna , one of crashes:

%MSG-e TkDetLayers: TSGFromL2Muon:hltL3NoFiltersNoVtxTrajSeedOIHit@streamBeginRun 02-Nov-2020 22:00:27 CET Run: 1 Stream: 0
ForwardDiskSectorBuilderFromDet: Trying to build Petal Wedge from Dets at different z positions !! Delta_z = -0.951241
%MSG
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 02-Nov-2020 22:00:29.869 CET

ianna · 2020-11-03T07:20:40Z

@ianna , one of crashes:

%MSG-e TkDetLayers: TSGFromL2Muon:hltL3NoFiltersNoVtxTrajSeedOIHit@streamBeginRun 02-Nov-2020 22:00:27 CET Run: 1 Stream: 0
ForwardDiskSectorBuilderFromDet: Trying to build Petal Wedge from Dets at different z positions !! Delta_z = -0.951241
%MSG
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 02-Nov-2020 22:00:29.869 CET

I don’t think it’s related to the PR. This should not have any effect on the regular workflows.

cmsbuild · 2020-11-10T17:52:21Z

-1

Tested at: 3dd8bb7

CMSSW: CMSSW_11_2_X_2020-11-09-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d89e76/10603/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepDDSolid had ERRORS

cmsbuild · 2020-11-10T17:52:30Z

Comparison job queued.

cmsbuild · 2020-11-10T19:11:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d89e76/10603/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 22 edm output root files, 35 DQM output files

silviodonato · 2020-11-11T10:59:28Z

@ianna
both cms-sw/cmsdist#6382
and cms-sw/cmsdist#6391
have been merged.
Currently, the MagneticField/Engine unit test in 11_2_X (#31987).
This PR fixes the unit test failure in MagneticField/Engine but it gets a new failure in theDetectorDescription/DDCMS unit test related to the "title" comparison and it can be ignored for the time being, if I understood correctly from the sim meeting.

DDSolid.cppunit.cc:46:Assertion
Test name: testDDSolid::checkDDSolid
assertion failed
- Expression: title.compare(name) == 0

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0

---> test testDD4hepDDSolid had ERRORS

So it looks like it is convenient to merge this PR in 11_2_0_pre9

ianna · 2020-11-11T12:36:36Z

@ianna
both cms-sw/cmsdist#6382
and cms-sw/cmsdist#6391
have been merged.
Currently, the MagneticField/Engine unit test in 11_2_X (#31987).
This PR fixes the unit test failure in MagneticField/Engine but it gets a new failure in theDetectorDescription/DDCMS unit test related to the "title" comparison and it can be ignored for the time being, if I understood correctly from the sim meeting.
DDSolid.cppunit.cc:46:Assertion
Test name: testDDSolid::checkDDSolid
assertion failed
- Expression: title.compare(name) == 0

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0

---> test testDD4hepDDSolid had ERRORS
So it looks like it is convenient to merge this PR in 11_2_0_pre9

Yes, the unit test points to a title issue. I think, we can ignore it for the moment. I'll pin the ROOT team again. Thanks!

ianna · 2020-11-11T12:36:52Z

+1

cmsbuild · 2020-11-11T12:37:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-11-11T12:45:16Z

+1

silviodonato · 2020-11-11T12:46:47Z

merge

bsunanda · 2020-11-11T16:12:12Z

@ianna Are we now using the new dd4hep code for reflected solids and not ROOT ones?

ianna · 2020-11-11T16:17:12Z

@ianna Are we now using the new dd4hep code for reflected solids and not ROOT ones?

No, not yet. This TGeo reflection factory call should be disabled/removed:

cmssw/DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc

Line 2249 in 8917353

det.manager().ConvertReflections();

@ghugo83 is looking into this.

ghugo83 · 2020-11-11T17:35:31Z

Yes if the test of the reflections in CSCs in the latest DD4hep @MarkusFrankATcernch turns out to not show any surprising regression, I will deactivate the TGeo reflection.

bsunanda · 2020-11-11T17:37:47Z

@ianna @ghugo83 It will be good to test after the new dd4hep is integrated and use the PR which disables this. Could you please let me know once the PR is available

ghugo83 · 2020-11-11T17:40:36Z

@bsunanda The PR is straightforward, ok let me do it now then.
By the way, I noticed there are still overlaps in ECAL preshower with DD4hep ? - off-topic from this point though.

ghugo83 · 2020-11-11T17:55:22Z

DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc

@@ -2058,7 +2058,7 @@ static long load_dddefinition(Detector& det, xml_h element) {

    string fname = xml::DocumentHandler::system_path(element);
    bool open_geometry = dddef.hasChild(DD_CMU(open_geometry)) ? dddef.child(DD_CMU(open_geometry)) : true;
-    bool close_geometry = dddef.hasChild(DD_CMU(close_geometry)) ? dddef.hasChild(DD_CMU(close_geometry)) : false;
+    bool close_geometry = dddef.hasChild(DD_CMU(close_geometry)) ? dddef.hasChild(DD_CMU(close_geometry)) : true;


@ianna why not
bool close_geometry = true ?
This must be equivalent.
Or did you mean:
bool close_geometry = dddef.hasChild(DD_CMU(close_geometry)) ? dddef.child(DD_CMU(close_geometry)) : true;
instead?

Closing (or not) geometry should be controlled via configuration, so it should be:

bool close_geometry = dddef.hasChild(DD_CMU(close_geometry)) ? dddef.hasChild(DD_CMU(close_geometry)) : false;

but there are places in the configurations where the close_geometry tag is not present, but needed. For example, in the MagneticField geometry. It needs a special "hidden" volume.

ghugo83 · 2020-11-11T18:06:17Z

@bsunanda Handled here: #32112

ianna · 2020-11-12T09:08:45Z

@ianna
both cms-sw/cmsdist#6382
and cms-sw/cmsdist#6391
have been merged.
Currently, the MagneticField/Engine unit test in 11_2_X (#31987).
This PR fixes the unit test failure in MagneticField/Engine but it gets a new failure in theDetectorDescription/DDCMS unit test related to the "title" comparison and it can be ignored for the time being, if I understood correctly from the sim meeting.
DDSolid.cppunit.cc:46:Assertion
Test name: testDDSolid::checkDDSolid
assertion failed
- Expression: title.compare(name) == 0

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0

---> test testDD4hepDDSolid had ERRORS
So it looks like it is convenient to merge this PR in 11_2_0_pre9

fixed via #32112

always close geometry

3dd8bb7

cmsbuild added this to the CMSSW_11_2_X milestone Nov 2, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Nov 2, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 2, 2020

cmsbuild mentioned this pull request Nov 2, 2020

[ROOT] Update root to latest 6.22 patches branch cms-sw/cmsdist#6353

Closed

cmsbuild added requires-external tests-started and removed tests-pending labels Nov 2, 2020

ianna mentioned this pull request Nov 2, 2020

test MagneticFieldEngineTestDriver had ERRORS #31987

Closed

cmsbuild added tests-rejected and removed tests-started labels Nov 2, 2020

This was referenced Nov 3, 2020

Minor updates to CUDA and OpenMPI cms-sw/cmsdist#6354

Merged

Update 6-22 on cmsdist master with one fix cms-sw/cmsdist#6364

Closed

cmsbuild added the tests-started label Nov 10, 2020

cmsbuild added tests-rejected and removed tests-started labels Nov 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Nov 11, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 11, 2020

cmsbuild merged commit 2f1139c into cms-sw:master Nov 11, 2020

ghugo83 reviewed Nov 11, 2020

View reviewed changes

ghugo83 mentioned this pull request Nov 11, 2020

Remove use of TGeo to convert reflections #32112

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] always close geometry #32000

[DD4hep] always close geometry #32000

ianna commented Nov 2, 2020

ianna commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

ianna commented Nov 2, 2020

ianna commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020 •

edited

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

civanch commented Nov 2, 2020

ianna commented Nov 3, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

silviodonato commented Nov 11, 2020

ianna commented Nov 11, 2020

ianna commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

silviodonato commented Nov 11, 2020

silviodonato commented Nov 11, 2020

bsunanda commented Nov 11, 2020

ianna commented Nov 11, 2020

ghugo83 commented Nov 11, 2020

bsunanda commented Nov 11, 2020

ghugo83 commented Nov 11, 2020

ghugo83 Nov 11, 2020 •

edited

ianna Nov 12, 2020

ghugo83 commented Nov 11, 2020

ianna commented Nov 12, 2020

[DD4hep] always close geometry #32000

[DD4hep] always close geometry #32000

Conversation

ianna commented Nov 2, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

ianna commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

ianna commented Nov 2, 2020

ianna commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020 • edited

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

cmsbuild commented Nov 2, 2020

civanch commented Nov 2, 2020

ianna commented Nov 3, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

silviodonato commented Nov 11, 2020

ianna commented Nov 11, 2020

ianna commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

silviodonato commented Nov 11, 2020

silviodonato commented Nov 11, 2020

bsunanda commented Nov 11, 2020

ianna commented Nov 11, 2020

ghugo83 commented Nov 11, 2020

bsunanda commented Nov 11, 2020

ghugo83 commented Nov 11, 2020

ghugo83 Nov 11, 2020 • edited

Choose a reason for hiding this comment

ianna Nov 12, 2020

Choose a reason for hiding this comment

ghugo83 commented Nov 11, 2020

ianna commented Nov 12, 2020

cmsbuild commented Nov 2, 2020 •

edited

ghugo83 Nov 11, 2020 •

edited