Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hgcal local reco from reconstruction_trackingOnlyTask for trackingPhase2PU140 (11_1_X backport) #32104

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

silviodonato
Copy link
Contributor

Backport of #31844

This backport fixes the crash in 20434.1
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_11_1/2020-11-10-2300?selectedArchs=slc7_amd64_gcc820&selectedFlavors=X&selectedStatus=failed

Tested in 20434.1.

From @slava77's PR:

This is in response to #31743 : reconstruction_trackingOnlyTask by default includes localrecoTask, which includes calolocalrecoTask, which in turn includes hgcalLocalRecoTask.
There are no actual dependencies on products made in hgcalLocalRecoTask.

This also removed castorreco from reconstruction_trackingOnlyTask, which is not needed/used either.

A recent update in #31527 introduced an explicit dependency of hgcalLocalRecoTask on tracking and broke reconstruction_trackingOnlyTask.
I propose to simply remove dependence on hgcalLocalRecoTask at this point (rather than picking individual unwanted modules).

tested on 23234.1 (phase-2 D49 trackingOnly wf)

@JanFSchulte @felicepantaleo @rovere

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_11_1_X.

It involves the following packages:

Configuration/StandardSequences

@silviodonato, @cmsbuild, @franzoni, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test with cms-sw/cmsdist#6340

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6340

@cmsbuild
Copy link
Contributor

+1
Tested at: 51dd9cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71a63d/10650/summary.html
CMSSW: CMSSW_11_1_X_2020-11-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71a63d/10650/summary.html

There are some workflows for which there are errors in the baseline:
136.731 step 2
136.793 step 2
136.874 step 2
135.4 step 1
1306.0 step 2
140.56 step 2
1330.0 step 2
158.0 step 2
10042.0 step 2
25202.0 step 2
10024.0 step 2
10824.0 step 2
10224.0 step 2
11634.0 step 2
12434.0 step 2
23234.1001 step 1
20034.0 step 2
20434.0 step 2
21234.0 step 2
23234.0 step 2
250202.181 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 14
  • DQMHistoTests: Total histograms compared: 487483
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 487461
  • DQMHistoTests: Total skipped: 21
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 13 files compared)
  • Checked 97 log files, 8 edm output root files, 14 DQM output files

@silviodonato
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit cac2d77 into cms-sw:CMSSW_11_1_X Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants