HBHE: deal with negative/null TS #32146

mariadalfonso · 2020-11-15T19:13:48Z

first commit is needed to reuse the constants on the GPU
second commit fix instability of the fits when the amplitude is equal or less than the pedestal (reduce the effect of dark current in Phase2 )

cmsbuild · 2020-11-15T19:20:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32146/19817

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalCalo/HcalRecAlgos/interface/HcalConstants.h modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFitOOTPileupCorrection.h modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFunctor.h modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/src/MahiFit.cc modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/src/PulseShapeFitOOTPileupCorrection.cc modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/src/PulseShapeFunctor.cc modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32146/19817/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32146/19817/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-11-15T19:50:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32146/19818

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalCalo/HcalRecAlgos/interface/HcalConstants.h modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFitOOTPileupCorrection.h modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFunctor.h modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/src/MahiFit.cc modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/src/PulseShapeFitOOTPileupCorrection.cc modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalCalo/HcalRecAlgos/src/PulseShapeFunctor.cc modified in PR(s): Patatrack integration - HCAL local reconstruction (8/N) #31720, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-11-15T19:51:03Z

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @apsallid, @abdoulline, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-11-16T03:37:03Z

@cmsbuild please test

cmsbuild · 2020-11-16T03:37:28Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10767/console Started: 2020/11/16 06:55

cmsbuild · 2020-11-16T07:17:19Z

+1
Tested at: 2e4eb44
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11078b/10767/summary.html
CMSSW: CMSSW_11_2_X_2020-11-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-16T07:17:21Z

Comparison job queued.

cmsbuild · 2020-11-16T08:55:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11078b/10767/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 7908 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 39063
DQMHistoTests: Total nulls: 10
DQMHistoTests: Total successes: 2490201
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.032 KiB( 34 files compared)
DQMHistoSizes: changed ( 136.793 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.874 ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
Checked 148 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-11-17T09:08:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32146/19859

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalCalo/HcalRecAlgos/interface/HcalConstants.h modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - HCAL local reconstruction (8/N) #31720
- File RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFitOOTPileupCorrection.h modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - HCAL local reconstruction (8/N) #31720
- File RecoLocalCalo/HcalRecAlgos/interface/PulseShapeFunctor.h modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - HCAL local reconstruction (8/N) #31720
- File RecoLocalCalo/HcalRecAlgos/src/MahiFit.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - HCAL local reconstruction (8/N) #31720
- File RecoLocalCalo/HcalRecAlgos/src/PulseShapeFitOOTPileupCorrection.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - HCAL local reconstruction (8/N) #31720
- File RecoLocalCalo/HcalRecAlgos/src/PulseShapeFunctor.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - HCAL local reconstruction (8/N) #31720

cmsbuild · 2020-11-17T09:09:18Z

Pull request #32146 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2020-11-17T13:10:57Z

@cmsbuild please test

cmsbuild · 2020-11-17T13:11:21Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10804/console Started: 2020/11/17 14:35

cmsbuild · 2020-11-17T15:17:59Z

+1
Tested at: 92ab27b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11078b/10804/summary.html
CMSSW: CMSSW_11_2_X_2020-11-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-17T15:18:02Z

Comparison job queued.

cmsbuild · 2020-11-17T16:57:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11078b/10804/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 7325 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 41617
DQMHistoTests: Total nulls: 9
DQMHistoTests: Total successes: 2487648
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.028 KiB( 34 files compared)
DQMHistoSizes: changed ( 136.793 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.874 ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
Checked 148 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-11-19T19:57:14Z

+1

The fix applied is in accordance to what envisaged and planned in the PR description
Jenkins tests show only minor differences in the HCal quantities, which of course also propagate to higher level observables
The validation provided with single pion guns confirms the same

cmsbuild · 2020-11-19T19:57:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-11-20T00:20:04Z

+1

Update GPU code following cms-sw#32146.

isolate HcalConstants

e3635dd

cmsbuild added this to the CMSSW_11_2_X milestone Nov 15, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 15, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 15, 2020

deal with negative or null TS

2e4eb44

mariadalfonso force-pushed the from-CMSSW_11_2_0_pre9_NegTS branch from 36d19b4 to 2e4eb44 Compare November 15, 2020 19:42

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 15, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 15, 2020

cmsbuild mentioned this pull request Nov 15, 2020

Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Closed

cmsbuild added tests-started and removed tests-pending labels Nov 16, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 16, 2020

cmsbuild removed the comparison-pending label Nov 16, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels Nov 17, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 17, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 17, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 17, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Nov 19, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 20, 2020

cmsbuild merged commit 2917ab2 into cms-sw:master Nov 20, 2020

fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Nov 22, 2020

Synchronise GPU code with CPU updates (#576)

3ef20e5

Update GPU code following cms-sw#32146.

fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 26, 2020

Synchronise GPU code with CPU updates (#576)

3740b04

Update GPU code following cms-sw#32146.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBHE: deal with negative/null TS #32146

HBHE: deal with negative/null TS #32146

mariadalfonso commented Nov 15, 2020

cmsbuild commented Nov 15, 2020

cmsbuild commented Nov 15, 2020

cmsbuild commented Nov 15, 2020

slava77 commented Nov 16, 2020

cmsbuild commented Nov 16, 2020 •

edited

cmsbuild commented Nov 16, 2020

cmsbuild commented Nov 16, 2020

cmsbuild commented Nov 16, 2020

cmsbuild commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

slava77 commented Nov 17, 2020

cmsbuild commented Nov 17, 2020 •

edited

cmsbuild commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

perrotta commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

qliphy commented Nov 20, 2020

HBHE: deal with negative/null TS #32146

HBHE: deal with negative/null TS #32146

Conversation

mariadalfonso commented Nov 15, 2020

cmsbuild commented Nov 15, 2020

cmsbuild commented Nov 15, 2020

cmsbuild commented Nov 15, 2020

slava77 commented Nov 16, 2020

cmsbuild commented Nov 16, 2020 • edited

cmsbuild commented Nov 16, 2020

cmsbuild commented Nov 16, 2020

cmsbuild commented Nov 16, 2020

cmsbuild commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

slava77 commented Nov 17, 2020

cmsbuild commented Nov 17, 2020 • edited

cmsbuild commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

perrotta commented Nov 19, 2020

cmsbuild commented Nov 19, 2020

qliphy commented Nov 20, 2020

cmsbuild commented Nov 16, 2020 •

edited

cmsbuild commented Nov 17, 2020 •

edited