migrate to ESconsumes GeantPropagatorESProducer #32260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@makortel @Dr15Jones would be so kind to take a look to what is the problem here? |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32260/20026
|
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: TrackPropagation/Geant4e @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins.
|
civanch
reviewed
Nov 24, 2020
mmusich
force-pushed
the
GeantPropagatorESProducer_11_2_X
branch
from
ce68764
to
9efa291
Compare
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32260/20033
|
|
Pull request #32260 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
If I understand correctly the ESConsumes migration is done correctly and once that is fixed, this uncovers a further problem with Geant4e which is not seen in 10.6.x. Any further help is appreciated since until this is fixed we cannot close issue #31920 |
mmusich
changed the title
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
@mmusich , for me this G4Refitter.py is working for 10_6_X and fails in 11_2_X in a different way. Your crash means, that Geant4 geometry is not built in 11_2, my crash is different but the reason is similar. This is not Geant4e issue but this is the issue how Geant4 geometry is instantiated in 11_2 - we changed this place, when prepared migration to DD4Hep. Corresponding modifications should be propagated to G4Refitter.py for 11_2. What I miss - how G4Refitter.py is created? |
|
+1 |
Please let me know how it should be modified. Thanks |
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is an attempt to solve the issue reported at #31920 (comment)
Running the following test configuration in
CMSSW_11_2_X_2020-11-23-2300results in:PR validation:
Tested with the configuration linked above, unfortunately resulting into a segmentation fault.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport needed.