Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding infra. for L1T object scaling constants from DB -- 11_1_X #32320

Closed

Conversation

trtomei
Copy link
Contributor

@trtomei trtomei commented Nov 27, 2020

This PR adds initial infrastructure for the L1T-HLT interface for Phase2.
We add a new CondFormat for the L1TObjScalingConstants and a new DataRecord to hold that new format in a DB.

  • We added it to the standard test:
    CondFormats/HLTObjects/test/testSerializationHLTObjects.cpp

and ran scram b runtests with success!

  • We ran runTheMatrix.py -l limited -i all --ibeos with success.

This is a backport of #32137 . We need this to have a complete version of the Phase-2 HLT menu in CMSSW_11_1_X .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @trtomei (Thiago Tomei) for CMSSW_11_1_X.

It involves the following packages:

CondCore/HLTPlugins
CondFormats/DataRecord
CondFormats/HLTObjects

@cmsbuild, @yuanchao, @fwyzard, @christopheralanwest, @tocheng, @Martin-Grunewald, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 50cd4b6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f4f0d/11161/summary.html
CMSSW: CMSSW_11_1_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f4f0d/11161/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 28 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@christopheralanwest
Copy link
Contributor

hold

I would like to wait for comments from L1 experts on this proposal prior to merging. In fact, probably the PR to master, while technically fine, probably should have waited for their input.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Pull request has been put on hold by @christopheralanwest
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Dec 1, 2020
@silviodonato
Copy link
Contributor

@christopheralanwest do you have any news from the L1 experts ?

@christopheralanwest
Copy link
Contributor

@cbotta proposed to not use these object scaling constants. Unfortunately, the corresponding PR to master was already merged because of a miscommunication on my side. Are we certain that there is no use for the code? I'm wondering if PR #32137 should be reverted.

@fwyzard
Copy link
Contributor

fwyzard commented Dec 9, 2020 via email

@cbotta
Copy link
Contributor

cbotta commented Dec 9, 2020

L1DPG sent a mail to @fwyzard and @trtomei, replying to their proposal and request to support this. We explained why we don't think it is needed. We haven't received any comment on that thread yet.

@fwyzard
Copy link
Contributor

fwyzard commented Dec 9, 2020

We were told this was going to be discussed between the L1T and HLT coordinators, but apparently that hasn't happened yet...

@trtomei
Copy link
Contributor Author

trtomei commented Dec 9, 2020

For the TDR, we decided to go a different whilst this is hashed. We are going to live with the object scaling constants written in the python configuration files.

AlCa may close this PR, and revert #32137 (effectively deleting it from 11_3_X).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants