PUPPI v15 bug/crash fix for NANOAOD (106X backport)

[lathomas]

PR description:

This is a fix to #32076 that introduced a crash in NANOAOD workflows.
For the record, the crash only happens when running the NANO step alone, but is not visible when both NANO and DQM:@nanoAODDQM steps are run (hence why it wasn't spotted earlier).

The fix consists to rearrange the order of some modules.
In addition, it was noticed that some booleans were not properly set for MC when recreating the jet PUPPI collection. This is now corrected.

Finally, the V15 PUPPI was in fact NOT enabled in the previous PR for reNANOAOD since only the run2_miniAOD_UL modifier was considered. This is also corrected. (That last item is not a backport because V15 is run by default in master)

PR validation:

The two following commands (used in NANOAOD v8 validation and that previously failed) are now running fine.

cmsDriver.py --python_filename PPD-RunIISummer20UL17NanoAODv2-00001_1_cfg.py --eventcontent NANOEDMAODSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier NANOAODSIM --fileout file:PPD-RunIISummer20UL17NanoAODv2-00001.root --conditions 106X_mc2017_realistic_v8 --step NANO --filein "dbs:/DYJetsToLL_M-50_TuneCP5_13TeV-amcatnloFXFX-pythia8/RunIISummer20UL17MiniAOD-Pilot_106X_mc2017_realistic_v6-v2/MINIAODSIM" --era Run2_2017,run2_nanoAOD_106Xv1 --mc -n 1000

cmsDriver.py RECO --conditions 106X_dataRun2_v32 --customise Configuration/DataProcessing/Utils.addMonitoring --datatier NANOAOD --era Run2_2017,run2_nanoAOD_106Xv1 --eventcontent NANOEDMAOD --filein /store/data/Run2017F/JetHT/MINIAOD/09Aug2019_UL2017-v1/270000/1B3CEF31-C191-CA4B-A5F1-447647399163.root --fileout "file:ReReco-Run2017C-JetHT-02Dec2020_UL2017_pilot-00001.root" --nThreads 2 --number 1000 --python_filename "ReReco-Run2017C-JetHT-02Dec2020_UL2017_pilot-00001_0_cfg.py" --scenario pp --step NANO --data

The PUPPIMET is indeed different when running this command on 10_6_19 and on 10_6_19_patch1 with this PR added.
It is identical when the commands above are run without the run2_nanoAOD_106Xv1 modifier.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #32328

[cmsbuild]

A new Pull Request was created by @lathomas for CMSSW_10_6_X.

It involves the following packages:

CommonTools/PileupAlgos
PhysicsTools/NanoAOD

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @swertz, @ahinzmann, @jdolen, @gkasieczka, @hatakeyamak, @gpetruc, @peruzzim, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-11-29-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11148/console Started: 2020/11/30 08:07

[cmsbuild]

+1
Tested at: 4074911
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48bb68/11148/summary.html
CMSSW: CMSSW_10_6_X_2020-11-29-2300
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48bb68/11148/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214712
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214376
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 26 edm output root files, 34 DQM output files

[silviodonato]

urgent

[perrotta]

+1

• No reco changes involved, only nanoAOD
• Jenkins tests pass

[silviodonato]

test parameters:

• workflows = 136.8522,1325.61,1325.81

[cmsbuild]

Pull request #32329 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please check and sign again.

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 136.8522,1325.61,1325.81
• CMSSW_10_6_X_2020-11-30-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11159/console Started: 2020/11/30 17:36

[cmsbuild]

+1
Tested at: dd50beb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48bb68/11159/summary.html
CMSSW: CMSSW_10_6_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48bb68/11159/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214712
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214376
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 26 edm output root files, 34 DQM output files

[gouskos]

+xpog
Changes are as expected

[perrotta]

+1

• No relevant changes for reco since previous signature in PUPPI v15 bug/crash fix for NANOAOD (106X backport)  #32329 (comment)

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1