Set default value for jets w/o SV info in HI CSV tagger (112X)

[mandrenguyen]

PR description:

The heavy-ion version of the CSV tagger was introduced into 11_2 in #31660
A peak is observed at a discriminator value of 0.30755
This was tracked down to change made during the review of #31660 which changed the way jets with no secondary vertex are identified.
This PR reverts to the original logic, and these jets now take a value of -1, as they should.

PR validation:

Validated with wfs 140.5611 and 158.01

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #32326
Needed for HI reMiniAOD campaign

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_11_2_X.

It involves the following packages:

RecoBTag/Combined

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @JyothsnaKomaragiri, @emilbols, @andrzejnovak, @smoortga this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Pull request #32331 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #32331 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-30-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11199/console Started: 2020/12/01 10:22

[cmsbuild]

+1
Tested at: fef936c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6d3a7/11199/summary.html
CMSSW: CMSSW_11_2_X_2020-11-30-2300
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6d3a7/11199/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529564
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[perrotta]

+1

• Identical backport of Set default value for jets w/o SV info in HI CSV tagger  #32326
• It fixes the default value for the disciminator as intended
• Jenkins tests pass and show the effect of the fix in the HI miniAOD

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1