Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM/EcalMonitorTasks] Add MEM FE Status and Integrity Error Plots #32481

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

alejands
Copy link
Contributor

PR description:

During a MWGR in November 2020 (but also a few times in Run2) we noticed EcalElectronicsIds coming from the ECAL calibration stream with seemingly unphysical detector coordinates. Specifically, these were coming from the EcalIntegrityMemBlockSizeErrors collection and occurred for a number of events in runs 338624 and 338628. At least in run 338628, this was always occurring with the same unphysical coordinates:

MemBlockSizeError:
dccId: 24
towerId: 70

It turns out that towerIDs 69 and 70 correspond to the MEM boxes for most ECAL SMs. These MEM boxes also have a front-end (FE) status that was not being displayed, due to the code assuming these coordinates are unphysical.

Integrity errors for towerID 69 had been masked before not knowing that these towerIDs do have a meaning: 95eed04

In this PR we now handle the two additional tower IDs and plots the FE status and integrity errors for these MEM boxes. The plots contain two bins for each SM corresponding to tower IDs 69 and 70, respectively. The plots are indexed by ECAL DCC ID, where each DCC ID corresponds to a SM. The mapping from DCC ID to SM name appears below.

01:EE-07  19:EB-10  37:EB+10
02:EE-08  20:EB-11  38:EB+11
03:EE-09  21:EB-12  39:EB+12
04:EE-01  22:EB-13  40:EB+13
05:EE-02  23:EB-14  41:EB+14
06:EE-03  24:EB-15  42:EB+15
07:EE-04  25:EB-16  43:EB+16
08:EE-05  26:EB-17  44:EB+17
09:EE-06  27:EB-18  45:EB+18
10:EB-01  28:EB+01  46:EE+07
11:EB-02  29:EB+02  47:EE+08
12:EB-03  30:EB+03  48:EE+09
13:EB-04  31:EB+04  49:EE+01
14:EB-05  32:EB+05  50:EE+02
15:EB-06  33:EB+06  51:EE+03
16:EB-07  34:EB+07  52:EE+04
17:EB-08  35:EB+08  53:EE+05
18:EB-09  36:EB+09  54:EE+06

PR validation:

New plots successfully generated with online ECAL DQM workflow and uploaded to a private DQM GUI without any issues.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of the original PR here: #32443

This is done to ensure the changes are available in CMSSW_11_2_X, which would be used in the next MWGR in February 2021.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2020

A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_11_2_X.

It involves the following packages:

DQM/EcalMonitorTasks

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rchatter, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-212224/11627/summary.html
CMSSW: CMSSW_11_2_X_2020-12-14-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529570
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 202.358 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 7.783 KiB Ecal/MEM
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

backport of #32443

@silviodonato silviodonato changed the title Add MEM FE Status and Integrity Error Plots [DQM/EcalMonitorTasks] Add MEM FE Status and Integrity Error Plots Dec 15, 2020
@jfernan2
Copy link
Contributor

+1
Tested at Online DQM playback

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 16, 2020

+1

@cmsbuild cmsbuild merged commit d57bc72 into cms-sw:CMSSW_11_2_X Dec 16, 2020
@alejands alejands deleted the FixMEMPlots_11_2_X branch October 19, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants