Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC #32513

christopheralanwest · 2020-12-17T03:32:37Z

PR description:

Since PR #29767, which was merged in the 11_1_X series, the EMTF emulator has been configured using the global tag. However, the tags contained in the 2017, 2018, Run 3 or Phase-2 MC specified the incorrect firmware version. This PR updates the tags for L1TMuonEndCapParamsRcd as follows:

2017: L1TMuonEndCapParams_Stage2v1
2018, Run 3 and Phase 2: L1TMuonEndCapParams_Stage2v3_2018_HI_mc

In particular, despite the "HI" in the 2018 MC string, this is indeed the correct tag for pp collisions as well.

More detail can be found at https://indico.cern.ch/event/983008/#41-l1t-emtf-tag-for-run3-mc-gt.

The GT diffs are as follows:

2017 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_design_v1/113X_mc2017_design_v2

2017 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_realistic_v1/113X_mc2017_realistic_v2

2017 realistic cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017cosmics_realistic_deco_v1/113X_mc2017cosmics_realistic_deco_v2

2017 realistic cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017cosmics_realistic_peak_v1/113X_mc2017cosmics_realistic_peak_v2

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_design_v1/113X_upgrade2018_design_v2

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_v1/113X_upgrade2018_realistic_v2

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_HI_v1/113X_upgrade2018_realistic_HI_v2

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_HEfail_v1/113X_upgrade2018_realistic_HEfail_v2

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018cosmics_realistic_deco_v1/113X_upgrade2018cosmics_realistic_deco_v2

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018cosmics_realistic_peak_v1/113X_upgrade2018cosmics_realistic_peak_v2

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_design_v1/113X_mcRun3_2021_design_v2

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_v1/113X_mcRun3_2021_realistic_v2

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021cosmics_realistic_deco_v1/113X_mcRun3_2021cosmics_realistic_deco_v3

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_HI_v1/113X_mcRun3_2021_realistic_HI_v2

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2023_realistic_v1/113X_mcRun3_2023_realistic_v2

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2024_realistic_v1/113X_mcRun3_2024_realistic_v2

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v1/113X_mcRun4_realistic_v2

PR validation:

L1T experts have confirmed that this is the tag contains the correct firmware version. In addition, the following technical tests were performed:

addOnTests.py -j 8
runTheMatrix.py -l limited,10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but will be backported to 11_1_X and 11_2_X.

cmsbuild · 2020-12-17T03:39:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32513/20456

This PR adds an extra 12KB to repository

cmsbuild · 2020-12-17T03:40:07Z

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

christopheralanwest · 2020-12-17T03:43:42Z

test parameters

workflow = 10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0

christopheralanwest · 2020-12-17T03:44:33Z

please test

cmsbuild · 2020-12-17T08:44:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5595f0/11756/summary.html
CMSSW: CMSSW_11_3_X_2020-12-16-2300/slc7_amd64_gcc900

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5595f0/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5595f0/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5595f0/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5595f0/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5595f0/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5595f0/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2747311
DQMHistoTests: Total failures: 394
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2746894
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 153 log files, 37 edm output root files, 36 DQM output files

hjkwon260 · 2020-12-17T16:42:21Z

@christopheralanwest Thanks a lot for updating GTs and preparing the PR. The updated EMTF tag in new GTs looks correct to me.
To check if comparison tests looks expected or not, I also ping L1T EMTF experts. @eyigitba @jiafulow @rekovic I think they can comment more on this.

p.s. it's irrelevant with this request but recently I found out current phase-2 GT queue contains (perhaps) outdated tracker tags, and it seems this new GT(phase-2) also conatains inappropriate ones. Probably it should updated in near future?

silviodonato · 2020-12-17T16:45:48Z

urgent
for the HLT TDR release (11_1_X)

mmusich · 2020-12-17T16:52:45Z

@hjkwon260

p.s. it's irrelevant with this request but recently I found out current phase-2 GT queue contains (perhaps) outdated tracker tags, and it seems this new GT(phase-2) also conatains inappropriate ones. Probably it should updated in near future?

the phase-2 tracker conditions for relval workflows (as tested in release) are added as a customization on top of the auto:phase2_realistic Global Tag via this mechanism:

cmssw/Configuration/AlCa/python/autoCondPhase2.py

Lines 113 to 120 in 8a23c45

    
           def autoCondPhase2(autoCond): 
        
               for key,val in six.iteritems(phase2GTs): 
        
                   if len(val)==1 : 
        
                      autoCond[key] = ( autoCond[val[0]] ) 
        
                   else: 
        
                      autoCond[key] = ( autoCond[val[0]],) + val[1] 
        
               return autoCond

This is done in order to support multiple geometries (that need different conditions) at once.
That's fine for integration tests and IB + pre-release relvals, but for (large) production of samples a physical Global Tag is needed, as agreed long time ago with several parties (PdmV, AlCa, O&C).
That's the reason why when you take the snapshot of the phase-2 queue you don't see the correct tags. You always need to add by hand the ones included in the autoCondPhase2.py file for the appropriate geometry.

eyigitba · 2020-12-17T18:17:05Z

@christopheralanwest @hjkwon260 thanks a lot for the update.

The comparisons look good to me. We do expect some changes due to EMTF configuration and they look consistent with what we expect.

christopheralanwest · 2020-12-17T18:18:47Z

+1

cmsbuild · 2020-12-17T18:19:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-12-17T18:35:23Z

+1

reminder:

This PR is not a backport but will be backported to 11_1_X and 11_2_X.

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC

090ae05

cmsbuild added this to the CMSSW_11_3_X milestone Dec 17, 2020

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Dec 17, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 17, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2020

cmsbuild added the urgent label Dec 17, 2020

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Dec 17, 2020

cmsbuild added orp-approved and removed orp-pending labels Dec 17, 2020

cmsbuild merged commit 8adff94 into cms-sw:master Dec 17, 2020

This was referenced Dec 17, 2020

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC [11_2_X] #32532

Merged

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC [11_1_X] #32533

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC #32513

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC #32513

christopheralanwest commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

christopheralanwest commented Dec 17, 2020

christopheralanwest commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

hjkwon260 commented Dec 17, 2020

silviodonato commented Dec 17, 2020

mmusich commented Dec 17, 2020 •

edited

eyigitba commented Dec 17, 2020

christopheralanwest commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

silviodonato commented Dec 17, 2020

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC #32513

Use correct L1TMuonEndCapParams tag for 2017, 2018, Run 3 and Phase 2 MC #32513

Conversation

christopheralanwest commented Dec 17, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

christopheralanwest commented Dec 17, 2020

christopheralanwest commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

Comparison Summary

hjkwon260 commented Dec 17, 2020

silviodonato commented Dec 17, 2020

mmusich commented Dec 17, 2020 • edited

eyigitba commented Dec 17, 2020

christopheralanwest commented Dec 17, 2020

cmsbuild commented Dec 17, 2020

silviodonato commented Dec 17, 2020

mmusich commented Dec 17, 2020 •

edited