Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCal ID variables #32519

Merged
merged 19 commits into from
Jan 8, 2021
Merged

HGCal ID variables #32519

merged 19 commits into from
Jan 8, 2021

Commits on Dec 17, 2020

  1. First commit.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    41f3043 View commit details
    Browse the repository at this point in the history

  2. Code formatting.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    89a2e50 View commit details
    Browse the repository at this point in the history

  3. Implemented first set of Sam's comments.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    3f9799d View commit details
    Browse the repository at this point in the history

  4. Implemented Sam's 2nd set of comments.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    2f8be5a View commit details
    Browse the repository at this point in the history

  5. adding HGCalClusterTools and HGCalID variable producer

    @Sam-Harper @SohamBhattacharya
    Sam-Harper authored and SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9da375d View commit details
    Browse the repository at this point in the history

  6. Implemented: cms-sw#32519 (comment)

    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9afea05 View commit details
    Browse the repository at this point in the history

  7. addressing review comments

    @Sam-Harper
    Sam-Harper committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    bf57b1d View commit details
    Browse the repository at this point in the history

  8. Merge pull request #3 from Sam-Harper/HGCal_ShowerShapes_11_2_0_pre7 

    addressing review comments
    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5fdf813 View commit details
    Browse the repository at this point in the history

  9. Implemented review comments.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    e3e931f View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Implemented latest set of review comments.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    2626651 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Review comments.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    1426f18 View commit details
    Browse the repository at this point in the history

  2. Added an additional safety check before eigen-value calculation.

    @SohamBhattacharya
    SohamBhattacharya committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    58c99c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. review comments

    @Sam-Harper
    Sam-Harper committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    da3597c View commit details
    Browse the repository at this point in the history

  2. temporary HGcal layer cluster isolation producer

    @khaosmos93 @Sam-Harper
    khaosmos93 authored and Sam-Harper committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    bc80b81 View commit details
    Browse the repository at this point in the history

  3. minor code style fixes

    @Sam-Harper
    Sam-Harper committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    02d7790 View commit details
    Browse the repository at this point in the history

  4. adding example test sequence as requested by reco

    @Sam-Harper
    Sam-Harper committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    833d51f View commit details
    Browse the repository at this point in the history

  5. Merge pull request #5 from Sam-Harper/HGCal_ShowerShapes_11_2_0_pre7_… 

    …WithExample

Adding Example config for Reco:

cmsDriver.py hltTest --python_filename egHLTPhaseIITest_cfg.py --eventcontent AODSIM --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000,Configuration/DataProcessing/Utils.addMonitoring --step RAW2DIGI,RECO --datatier AODSIM  --conditions auto:phase2_realistic_T15 --geometry Extended2026D49 --nThreads 4 --filein /store/mc/Phase2HLTTDRSummer20ReRECOMiniAOD/DoubleElectron_FlatPt-1To100/GEN-SIM-DIGI-RAW-MINIAOD/PU200_111X_mcRun4_realistic_T15_v1-v2/280000/1B09CC5D-FAA3-5442-BE7B-96302835E860.root --era Phase2C9 --no_exec --mc --customise_commands "process.load('RecoEgamma.EgammaHLTProducers.HLTEgPhaseIITestSequence_cff');process.HLT_EgPhaseIITest_v1 = cms.Path(process.HLTEgPhaseIITestSequence);process.schedule.append(process.HLT_EgPhaseIITest_v1);process.AODSIMoutput.outputCommands.extend(['keep recoEcalCandidates*_*_*_*','keep recoRecoEcalCandidatesToValuefloatAssociation_*_*_*'])" -n 12 --processName=RECO2
    @SohamBhattacharya
    SohamBhattacharya committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    994d7f9 View commit details
    Browse the repository at this point in the history

  6. code checks & format

    @Sam-Harper
    Sam-Harper committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    5612e4d View commit details
    Browse the repository at this point in the history

  7. Merge pull request #6 from Sam-Harper/HGCal_ShowerShapes_11_2_0_pre7_… 

    …WithExample

updating with code checks
    @SohamBhattacharya
    SohamBhattacharya committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    de4af6a View commit details
    Browse the repository at this point in the history