Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to various packages #32562

Closed
wants to merge 5 commits into from

Conversation

makortel
Copy link
Contributor

PR description:

This PR adds missing dependencies to BuildFile.xml in various packages (and in case of DQM/DataScouting removes a few unnecessary header inclusions). In all cases headers from the added packages are #included in the corresponding package. These were found in UBSAN IBs (as build errors).

PR validation:

These packages build successfully in an UBSAN IB.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32562/20523

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/DataScouting
FastSimulation/ForwardDetectors
GeneratorInterface/ExhumeInterface
GeneratorInterface/TauolaInterface
IOMC/EventVertexGenerators
JetMETCorrections/Type1MET

@SiewYan, @perrotta, @andrius-k, @mkirsano, @lveldere, @kmaeshima, @civanch, @sbein, @ssekmen, @mdhildreth, @ErnestaP, @cmsbuild, @jpata, @jfernan2, @agrohsje, @fioriNTU, @slava77, @alberto-sanchez, @santocch, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @mkirsano, @ahinzmann, @jan-kaspar, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @alberto-sanchez, @matt-komm, @mariadalfonso, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@@ -14,5 +14,6 @@
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/VertexReco"/>
<use name="JetMETCorrections/Objects"/>
<use name="JetMETCorrections/JetCorrector"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc4f73/11813/summary.html
CMSSW: CMSSW_11_3_X_2020-12-18-1100/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@makortel
Copy link
Contributor Author

Closing in favor of @Dr15Jones' individual PRs.

@makortel makortel closed this Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants