New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependencies to various packages #32562
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32562/20523
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DQM/DataScouting @SiewYan, @perrotta, @andrius-k, @mkirsano, @lveldere, @kmaeshima, @civanch, @sbein, @ssekmen, @mdhildreth, @ErnestaP, @cmsbuild, @jpata, @jfernan2, @agrohsje, @fioriNTU, @slava77, @alberto-sanchez, @santocch, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@@ -14,5 +14,6 @@ | |||
<use name="DataFormats/PatCandidates"/> | |||
<use name="DataFormats/VertexReco"/> | |||
<use name="JetMETCorrections/Objects"/> | |||
<use name="JetMETCorrections/JetCorrector"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #32552 (comment)
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc4f73/11813/summary.html DAS Queries failed Comparison SummarySummary:
|
Closing in favor of @Dr15Jones' individual PRs. |
PR description:
This PR adds missing dependencies to BuildFile.xml in various packages (and in case of
DQM/DataScouting
removes a few unnecessary header inclusions). In all cases headers from the added packages are#include
d in the corresponding package. These were found in UBSAN IBs (as build errors).PR validation:
These packages build successfully in an UBSAN IB.