Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fireworks proxies for Tracksters and fix a bug in FWCaloClusterProxyBuilder.cc #32569

Merged
merged 16 commits into from
Dec 22, 2020

Conversation

chrispap95
Copy link
Contributor

PR description:

Add the following proxies for Tracksters visualization:

  • FWTracksterHitsProxyBuilder.cc: Displays hits that belong to the cluster after loading the LayerClusters.
  • FWTracksterProxyBuilder.cc: Displays tracksters as ellipsoids.

Fix type of TimeValueMapHandle in FWCaloClusterProxyBuilder.cc

PR validation:

Tested manually using single photon and ttbar samples.

if this PR is a backport please specify the original PR and why you need to backport that PR:

It isn't a backport.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32569/20544

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chrispap95 (Chris Papageorgakis) for master.

It involves the following packages:

Fireworks/Calo

@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented Dec 21, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9de364/11832/summary.html
CMSSW: CMSSW_11_3_X_2020-12-21-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716935
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Dec 22, 2020

+1

@cmsbuild cmsbuild merged commit d10412c into cms-sw:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants