Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(11_1_X) L1 Phase2 for HLT TDR - Multy Primary Vtx, TkMuons Fix for low-pt #32681

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jan 19, 2021

PR description:

11_1_X PR (backport of #32571)

LT Phase2 for HLT TDR, featuring:

  • Multy Primary Vtx: adjust the producer to provide more than just the best-ranked PrimVtx (ported from integration tag l1t-phase2-v3.3.5)
  • TkMuons Fix for low-pt: do the the cleaning of duplicate between regions to reduce rate and keep efficiency (ported from integration tag l1t-phase2-v3.3.0)

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

(backport of #32571)

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_11_1_X.

It involves the following packages:

DataFormats/L1TCorrelator
L1Trigger/L1TTrackMatch

@cmsbuild, @rekovic, @srimanob, @kpedro88, @jmduarte can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Jan 19, 2021

please test

@silviodonato
Copy link
Contributor

urgent

@silviodonato
Copy link
Contributor

(for HLT TDR)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6a2aa/12350/summary.html
COMMIT: 1a7aa3b
CMSSW: CMSSW_11_1_X_2021-01-17-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

…Use edm::stream producer, Adjust produce method.
@cmsbuild
Copy link
Contributor

Pull request #32681 was updated. @cmsbuild, @rekovic, @srimanob, @kpedro88, @jmduarte can you please check and sign again.

@srimanob
Copy link
Contributor

Please test

@silviodonato silviodonato changed the title (11_1_X) LT Phase2 for HLT TDRT - Multy Primary Vtx, TkMuons Fix for low-pt (11_1_X) L1 Phase2 for HLT TDR - Multy Primary Vtx, TkMuons Fix for low-pt Jan 20, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6a2aa/12386/summary.html
COMMIT: 31d2640
CMSSW: CMSSW_11_1_X_2021-01-19-2300/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32681/12386/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Jan 20, 2021

*1

@rekovic
Copy link
Contributor Author

rekovic commented Jan 20, 2021

+1

@silviodonato
Copy link
Contributor

The IB test of 11_3_X with #32571 are ok. So, if there are no objections from @cms-sw/upgrade-l2, I would merge this PR in time for the morning IB.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit fe7f622 into cms-sw:CMSSW_11_1_X Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants