Update ECAL spike killer settings for Run 3

[christopheralanwest]

PR description:

This PR provides re-optimized ECAL spike killer settings for Run 3. Details of the payloads and their validation can be found in the presentation at the 18 Jan 2021 AlCaDB meeting.

The GT diffs are as follows:

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_v2/113X_mcRun3_2021_realistic_v3

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021cosmics_realistic_deco_v3/113X_mcRun3_2021cosmics_realistic_deco_v4

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_HI_v2/113X_mcRun3_2021_realistic_HI_v3

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2023_realistic_v2/113X_mcRun3_2023_realistic_v3

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2024_realistic_v2/113X_mcRun3_2024_realistic_v3

PR validation:

The payloads were validated by explicitly comparing dumps of the new payload with the old (see slide 5) and checking the performance with re-emulated trigger primitives (see slide 6).

In addition, a technical test was performed:

runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but a backport to 112X has been requested for use in Run 3 MC production.

[christopheralanwest]

test parameters

• workflow = 12024.0,7.23,159.0,12834.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32701/20815

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a5b8/12400/summary.html
COMMIT: b388c84
CMSSW: CMSSW_11_3_X_2021-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32701/12400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b4a5b8/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b4a5b8/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[christopheralanwest]

hold

Prior to merging, I would like to have an answer to the question raised here: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4364/1/1/1.html

[cmsbuild]

Pull request has been put on hold by @christopheralanwest
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[christopheralanwest]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32701/20826

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #32701 was updated. @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a5b8/12429/summary.html
COMMIT: 5468662
CMSSW: CMSSW_11_3_X_2021-01-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32701/12429/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b4a5b8/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b4a5b8/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[christopheralanwest]

unhold

ECAL experts requested to revert the changes to the 2021 design GT. This change was done in commit 5468662.

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1