Sort the imports in the split configurations #32754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32754/20909
|
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/ParameterSet @makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: Python3 #Python3 I found errors: *** Error compiling 'src/FWCore/ParameterSet/python/Config.py'... |
|
looks like Python 3 removed support for tuple unpacking via PEP 3113 - good job guys |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-rejected
labels
fwyzard
force-pushed
the
edmConfigSplit_sort_imports
branch
from
6062c06
to
375372a
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32754/20973
|
|
Pull request #32754 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
|
please test |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Unit TestsI found errors in the following unit tests: ---> test testFWCoreFrameworkModuleDeletion had ERRORS ---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS ---> test testPhase2PixelNtuple had ERRORS and more ... RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ... |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32754/20984
|
|
Pull request #32754 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
-1 Failed Tests: UnitTests AddOn Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS ---> test unitTestsGroup_1 had ERRORS ---> test unitTestsGroup_4 had ERRORS and more ... AddOn Tests
Comparison SummarySummary:
|
|
All failures appear to be in the IB already, but I'd prefer one round of tests with the next IB that should clean with at least some of those. |
|
please test
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31fce0/12792/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
When generating a split configuration, sort the import in each file by section and by module name.
For example, before:
after:
PR validation:
None.