New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSC RU builder widened roads and narrower anode time window switched to default #32948
Conversation
not needed as the customisation switched to default
not needed as the changes used as default for reco
narrower anode time window used as default
the bool parameter not needed, as it is considered True as default
the bool parameter not needed anymore as it is considered True as default
the configuration parameter "enlarge" not needed as it is set True as default
@ptcox, you might be interested |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32948/21179
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
code format fixed
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32948/21180
|
A new Pull Request was created by @nvoytish for master. It involves the following packages: RecoLocalMuon/CSCRecHitD @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-046035/12974/summary.html Comparison SummarySummary:
|
@nvoytish I ran the workflow 136.875_RunDoubleMuon2018C+RunDoubleMuon2018C+HLTDR2_2018+RECODR2_2018reHLT_Offline+HARVEST2018 with 100 events and two configurations to validate that the migration from the customisation functions is complete (separately of the physics validation you have linked above).
from RecoLocalMuon.CSCRecHitD.customRecHitBuilder import tightenAnodeTimes
from RecoLocalMuon.CSCSegment.customSegmentBuilder import widenRoads
process = tightenAnodeTimes(process)
process = widenRoads(process)
# Add early deletion of temporary data products to reduce peak memory need
from Configuration.StandardSequences.earlyDeleteSettings_cff import customiseEarlyDelete
process = customiseEarlyDelete(process)
I observe don't observe any differences in the reco outputs that are monitored. The code changes also look OK to me. I will sign in a separate post. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a PR that omitts the customisation files and confirable parameter used for validation of the proposed changes in #25684 and #17772
Related presentation can be found here https://indico.cern.ch/event/784929/contributions/3265299/attachments/1777781/2890942/19_01_11-Voytishin_Palichik-CSCSegBuilder_proposal_RECO_meeting.pdf
The results of the validation can be found here:
https://hypernews.cern.ch/HyperNews/CMS/get/muon-object-validation/1287/1.html