Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RivetInterface fixes+updates (11_2) #33052

Merged
merged 6 commits into from
Mar 4, 2021

Conversation

mseidel42
Copy link
Contributor

Backport of #32950

PR description:

  • Fix problem that leads to nan cross sections since Rivet 3.1.1 (Rivet 3.1.0 in 11_1 is ok)
  • Add check for nan cross section to unit tests, to prevent this from going unnoticed again
  • Add tests for yodamerge+yoda2root
  • Pass new Rivet AnalysisHandler options for (de)selecting weights, weight cap, etc.

PR validation:

  • Passes new test that cross section is not nan
  • New options behave as expected for selecting weights

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_11_2_X.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@agrohsje
Copy link

agrohsje commented Mar 3, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd0a6d/13237/summary.html
COMMIT: 4f24f89
CMSSW: CMSSW_11_2_X_2021-03-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33052/13237/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2528845
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2528816
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@agrohsje
Copy link

agrohsje commented Mar 4, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 4, 2021

+1

@cmsbuild cmsbuild merged commit 0b36de4 into cms-sw:CMSSW_11_2_X Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants