Calo boundary Information #33056

rovere · 2021-03-03T16:53:10Z

PR description:

This PR adds the information at CALO boundary to the default configuration.

PR validation:

runTheMatrix limited.

cmsbuild · 2021-03-03T17:08:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33056/21361

This PR adds an extra 24KB to repository

cmsbuild · 2021-03-03T17:08:35Z

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

rovere · 2021-03-03T17:09:23Z

@cmsbuild please test

rovere · 2021-03-03T17:09:36Z

FYI @cseez

cmsbuild · 2021-03-03T20:59:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c36a6/13249/summary.html
COMMIT: b8e1f85
CMSSW: CMSSW_11_3_X_2021-03-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33056/13249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2903 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 106449
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2644511
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

cmsbuild · 2021-03-04T08:00:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33056/21372

This PR adds an extra 32KB to repository

cmsbuild · 2021-03-04T08:01:04Z

Pull request #33056 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

rovere · 2021-03-04T08:04:04Z

@cmsbuild please test

cmsbuild · 2021-03-04T12:14:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c36a6/13261/summary.html
COMMIT: 50db983
CMSSW: CMSSW_11_3_X_2021-03-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33056/13261/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2900 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2749431
DQMHistoTests: Total failures: 78464
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2670945
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

civanch · 2021-03-04T12:19:06Z

SimG4Core/Application/python/g4SimHits_cfi.py

    DelivLuminosity = cms.double(5000.)
 )

 common_MCtruth = cms.PSet(
    DoFineCalo = cms.bool(False),
+    SaveCaloBoundaryInformation = cms.bool(False),


@rovere , I am sorry, can you imagine that somebody want DoFineCalo=True and SaveCaloBoundaryInformation=False?

What is the use case?

Ciao @civanch
thanks for looking into that!
The use case here is that we would like to have the information at the caloBoundary without requesting the full complexity of tracing everything within the fine-calo volumes.
The two flags, in this sense, are complementary.

@rovere , why we see differences in Phase-2 WFs? I would expect regression for this PR. DD4Hep WF may be fine so far.

ciao @civanch
the flag is set to false for all workflows but for Phase2 ones.
The changes are mostly coming from SimTracks that are now saved if they have the crossedBoundary flag set. I found this useful to correctly assign hits to SimTrack and SimClusters.
The extent of the changes is rather limited and of limited impact on the high level Validation.

The DD4HEP workflows shows many differences, but I'm not sure where they are coming from, but you seem to suggest that is fine, right?

civanch · 2021-03-04T12:59:50Z

@rovere , why we see differences in Phase-2 WFs? I would expect regression for this PR. DD4Hep WF may be fine so far.

civanch · 2021-03-04T13:49:07Z

+1

cmsbuild · 2021-03-04T13:49:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-03-04T14:59:49Z

+1

ciao @civanch
the flag is set to false for all workflows but for Phase2 ones.
The changes are mostly coming from SimTracks that are now saved if they have the crossedBoundary flag set. I found this useful to correctly assign hits to SimTrack and SimClusters.
The extent of the changes is rather limited and of limited impact on the high level Validation.

rovere added 3 commits March 2, 2021 17:34

Add calo-boundary information to simtracks

0535062

Set calo-boundary information

f6b9b62

Code format

b8e1f85

cmsbuild added this to the CMSSW_11_3_X milestone Mar 3, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Mar 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 3, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 3, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 3, 2021

Activate CaloBoundary information only for Phase2 workflows

50db983

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Mar 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 4, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 4, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 4, 2021

civanch reviewed Mar 4, 2021

View reviewed changes

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Mar 4, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 4, 2021

cmsbuild merged commit f69e28e into cms-sw:master Mar 4, 2021

tklijnsma mentioned this pull request Jul 9, 2021

finecalo patches v2: Performance improvements #34431

Closed

tklijnsma mentioned this pull request Jul 22, 2021

Fixed finecalo performance #34597

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calo boundary Information #33056

Calo boundary Information #33056

rovere commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

rovere commented Mar 3, 2021

rovere commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 4, 2021

cmsbuild commented Mar 4, 2021

rovere commented Mar 4, 2021

cmsbuild commented Mar 4, 2021

civanch Mar 4, 2021 •

edited

rovere Mar 4, 2021 •

edited

civanch Mar 4, 2021

rovere Mar 4, 2021

civanch commented Mar 4, 2021

civanch commented Mar 4, 2021

cmsbuild commented Mar 4, 2021

silviodonato commented Mar 4, 2021

Calo boundary Information #33056

Calo boundary Information #33056

Conversation

rovere commented Mar 3, 2021

PR description:

PR validation:

cmsbuild commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

rovere commented Mar 3, 2021

rovere commented Mar 3, 2021

cmsbuild commented Mar 3, 2021

Comparison Summary

cmsbuild commented Mar 4, 2021

cmsbuild commented Mar 4, 2021

rovere commented Mar 4, 2021

cmsbuild commented Mar 4, 2021

Comparison Summary

civanch Mar 4, 2021 • edited

Choose a reason for hiding this comment

rovere Mar 4, 2021 • edited

Choose a reason for hiding this comment

civanch Mar 4, 2021

Choose a reason for hiding this comment

rovere Mar 4, 2021

Choose a reason for hiding this comment

civanch commented Mar 4, 2021

civanch commented Mar 4, 2021

cmsbuild commented Mar 4, 2021

silviodonato commented Mar 4, 2021

civanch Mar 4, 2021 •

edited

rovere Mar 4, 2021 •

edited