Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on the indexing of VFATs in GEM onlineDQM, backport to CMSSW_11_2_X #33192

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Mar 16, 2021

PR description:

We modified the structure of GEM onlineDQM in the last time (#32791, #32792), and this is a fix for an issue on the indexing of VFATs. No fix on DQM GUI is necessary for this.

This is for the backport to CMSSW_11_2_X.

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij @hyunyong

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 16, 2021

A new Pull Request was created by @quark2 for CMSSW_11_2_X.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@quark2 quark2 changed the title Fix on the indexing of VFATs Fix on the indexing of VFATs, backport to CMSSW_11_2_X Mar 16, 2021
@quark2 quark2 changed the title Fix on the indexing of VFATs, backport to CMSSW_11_2_X Fix on the indexing of VFATs in GEM onlineDQM, backport to CMSSW_11_2_X Mar 16, 2021
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6f1b9/13559/summary.html
COMMIT: 27f56e9
CMSSW: CMSSW_11_2_X_2021-03-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33192/13559/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2527466
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Tested at Online DQM at P5 too

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@jfernan2
Copy link
Contributor

backport of #33193

@qliphy
Copy link
Contributor

qliphy commented Mar 18, 2021

+1

@cmsbuild cmsbuild merged commit 55f80fe into cms-sw:CMSSW_11_2_X Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants