Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ: generate cfi file for output module (11_2_X) #33217

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

smorovic
Copy link
Contributor

PR description:

Modification to generate cfi file for EvFOutputModule.

PR validation:

At compile time it generates cfi file as intended:
cfipython/slc7_amd64_gcc900/EventFilter/Utilities/evfOutputModule_cfi.py

evfOutputModule = cms.OutputModule('EvFOutputModule',
  max_event_size = cms.untracked.int32(7000000),
  use_compression = cms.untracked.bool(True),
  compression_algorithm = cms.untracked.string('ZLIB'),
  compression_level = cms.untracked.int32(1),
  lumiSection_interval = cms.untracked.int32(0),
  outputCommands = cms.untracked.vstring('keep *'),
  SelectEvents = cms.untracked.PSet(
    SelectEvents = cms.optional.vstring
  ),
  psetMap = cms.untracked.InputTag('hltPSetMap')
)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of a commit c8aa48b
from #33198

Backporting to allow work on changing the output module name in HLT ConfDB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2021

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_11_2_X.

It involves the following packages:

EventFilter/Utilities

@perrotta, @emeschi, @cmsbuild, @slava77, @jpata, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ce372/13618/summary.html
COMMIT: 3bf949c
CMSSW: CMSSW_11_2_X_2021-03-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33217/13618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2527472
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor Author

+1

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2021

+1

for #33217 3bf949c

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 23, 2021

+1

@cmsbuild cmsbuild merged commit 20a37ed into cms-sw:CMSSW_11_2_X Mar 23, 2021
@smorovic smorovic deleted the 112X-evfoutput-cfi branch August 24, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants