Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ECAL supercluster parameters to run2_mc_50ns GT #33239

Conversation

francescobrivio
Copy link
Contributor

PR description:

Adding Ecal supercluster paramaters to the run2_mc_50ns GT in order to align 11_2_X release with master.
Addressing issue #33237.

The GT diff is:
Run 2 startup
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_startup_v1/112X_mcRun2_startup_v2

PR validation:

Tested with: runTheMatrix.py -l 50200.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for CMSSW_11_2_X.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 50200.0

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad0e60/13650/summary.html
COMMIT: 1f63f39
CMSSW: CMSSW_11_2_X_2021-03-21-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33239/13650/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ad0e60/50200.0_ZEE_13+ZEE_13+DIGIUP15_PU50+RECOUP15_PU50_L1TEgDQM+HARVESTUP15_PU50_L1TEgDQM

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2527475
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@christopheralanwest
Copy link
Contributor

+alca

  • resolves missing record exception in workflow 50200.0

@christopheralanwest
Copy link
Contributor

resolves #33237

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@christopheralanwest
Copy link
Contributor

urgent

This is needed to resolve a crash in IBs

@qliphy
Copy link
Contributor

qliphy commented Mar 21, 2021

+1

@cmsbuild cmsbuild merged commit b57ae13 into cms-sw:CMSSW_11_2_X Mar 21, 2021
@francescobrivio francescobrivio deleted the alca-EcalMustacheSCParameters_fix_11_2_X branch June 16, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants