Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change binning of TP occupnacy vs BX plot and edit BX plot descriptions #33275

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

alejands
Copy link
Contributor

PR description:

This PR is fulfilling a request from ECAL DAQ to change the binning in the TP occupancy vs BX plot to have finer BX bins. The new binning is by BX rather than by groups of BXs, similar to the Timing vs BX finely binned plot used in Offline DQM. This leads to the new plot to be quite busy with many bins, but the expectation is that DAQ experts will zoom in on the x-axis using the Customize button on the DQM GUI to study their region of interest.

Slight modifications were made to the TrigPrimTask module so the way the BX binning is done more closely matches what is done in the TimingTask module, which also contain some “vs BX” plots. Some plot descriptions were also updated to mention relevant information for these plots, such as the BX ids starting at 1, as well as a minor relabelling of the x-axis.

PR validation:

An Online DQM-like workflow was run and the plots were uploaded to a private DQM GUI. We verified with ECAL DAQ that the new binning was to their liking. We also verified that the new BX binning changes did not affect any other plot binned by BX.

Validations were rerun on the backport with no differences from the original PR.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of the following PR: #33264

The changes are wanted in CMSSW_11_2_X, to be used by DQM in the upcoming MWGR in April 2021.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_11_2_X.

It involves the following packages:

DQM/EcalMonitorTasks

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56dae3/13794/summary.html
COMMIT: aded279
CMSSW: CMSSW_11_2_X_2021-03-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33275/13794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 72
  • DQMHistoTests: Total successes: 2527399
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2183.996 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 56.000 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 1000.0,... ): 28.000 KiB EcalBarrel/EBTriggerTowerTask
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

I apologize for the delay but our DQM developer is on holidays these days and we would like to test this PR at DQM@P5 next week after Easter

@jfernan2
Copy link
Contributor

+1
Tested at Online DQM@P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

@alejands please note there is a comment here https://github.com/cms-sw/cmssw/pull/33264/files#r605397948

@silviodonato
Copy link
Contributor

+1
I prefer to include this PR before the long weekend, in order to build 11_2_X in advance

@cmsbuild cmsbuild merged commit 5ee4931 into cms-sw:CMSSW_11_2_X Apr 2, 2021
@alejands alejands deleted the TPBXBinning_112X branch October 19, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants