Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DQM/TrackerRemapper package #33280

Merged
merged 31 commits into from Apr 8, 2021
Merged

Add DQM/TrackerRemapper package #33280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
cf03a7f
Created Strip Tracker Map Remapper/Analyzer
pjurgielewicz Nov 28, 2017
dcbfdaf
move Phase1PixelMaps and SiStripTkMaps from CondCore/SiPixelPlugins t…
mmusich Jan 6, 2021
29324ae
fix TrackerRemapper includes and BuildFile
mmusich Jan 6, 2021
4622a27
improve/modernize TrackerRemapper
mmusich Jan 7, 2021
4339b33
update configuration file and README
mmusich Jan 8, 2021
d89aa4f
refine TrackerRemapper: add fillDescriptions
mmusich Jan 8, 2021
a121e52
rename member variables according to cmssw code-rules
mmusich Jan 11, 2021
dfaebcb
add possibility to plot Pixel maps both barrel and endcaps
mmusich Jan 11, 2021
c1ca088
New Offline Pixel Detector Analyzer
pjurgielewicz Mar 8, 2017
3d966a1
Added README file
pjurgielewicz Mar 9, 2017
124ae74
README formatting fix #1
pjurgielewicz Mar 9, 2017
ec503ce
modernize SiPixelPhase1Analyzer
mmusich Jan 12, 2021
f0997c7
make methods conform to cmssw code rules
mmusich Jan 12, 2021
a6eb0fc
move DQM/SiPixelPhase1Analyzer to DQM/TrackerRemapper
mmusich Feb 13, 2021
e1ac297
modernize SiPixelPhase1Analyzer
mmusich Feb 15, 2021
54eaf24
compiles fine both in debug and standard mode
mmusich Feb 15, 2021
a54ba41
now working configurations for boyh Phase-1 analyzer and tracker-rema…
mmusich Feb 15, 2021
00c155f
newlines at the end of files
mmusich Feb 16, 2021
7c22337
add features to Phase1PixelMap.h
mmusich Feb 17, 2021
043663a
miscellaneuous fixes
mmusich Feb 25, 2021
b932c00
add Phase1PixelSummaryMap and use a generic Pixel Tracker Map class f…
mmusich Feb 25, 2021
becf421
add Phase1PixelROCMaps and use it
mmusich Mar 16, 2021
7c5ece2
general clean-up
mmusich Mar 20, 2021
6bbbca5
improve Phase1PixelROCMaps class
mmusich Mar 26, 2021
2ef339a
add full pixel map for SiPixelLorentzAngle and use it in tests
mmusich Mar 26, 2021
fa39152
fix final issues
mmusich Mar 26, 2021
791c709
fix header consistency and CMS code rules
mmusich Mar 29, 2021
0d02fcd
split header from implementation 1/3
mmusich Apr 6, 2021
f6bb01a
split header from implementation 2/3
mmusich Apr 6, 2021
193434d
improve naming of SiPixelFullPixelIDMap and use it also for 2D templates
mmusich Apr 6, 2021
18d8f14
split header from implementation 3/3
mmusich Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
65 changes: 33 additions & 32 deletions Alignment/OfflineValidation/plugins/BuildFile.xml
View file
Open in desktop
@@ -1,54 +1,55 @@
<use name="FWCore/MessageLogger"/>
<use name="TrackPropagation/SteppingHelixPropagator"/>
<use name="Alignment/CommonAlignment"/>
<use name="Alignment/TrackerAlignment"/>
<use name="CLHEP"/>
<use name="CalibTracker/StandaloneTrackerTopology"/>
<use name="CommonTools/TrackerMap"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CommonTools/Utils"/>
<use name="CondCore/DBOutputService"/>
<use name="CondFormats/BeamSpotObjects"/>
<use name="CondFormats/Alignment"/>
<use name="CondFormats/BeamSpotObjects"/>
<use name="CondFormats/RunInfo"/>
<use name="CondFormats/SiPixelObjects"/>
<use name="DataFormats/TrackReco"/>
<use name="DQM/TrackerRemapper"/>
<use name="DQMServices/Core"/>
<use name="DataFormats/BeamSpot"/>
<use name="DataFormats/DetId"/>
<use name="DataFormats/MuonDetId"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/SiStripDetId"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="DataFormats/TrackingRecHit"/>
<use name="DataFormats/TrajectorySeed"/>
<use name="DataFormats/VertexReco"/>
<use name="FWCore/Framework"/>
<use name="FWCore/Utilities"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/ServiceRegistry"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="CommonTools/TrackerMap"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CommonTools/Utils"/>
<use name="RecoMuon/TrackingTools"/>
<use name="CalibTracker/StandaloneTrackerTopology"/>
<use name="TrackingTools/TransientTrack"/>
<use name="SimDataFormats/Track"/>
<use name="SimDataFormats/GeneratorProducts"/>
<use name="SimTracker/TrackerHitAssociation"/>
<use name="DataFormats/DetId"/>
<use name="DataFormats/MuonDetId"/>
<use name="FWCore/Utilities"/>
<use name="Geometry/CaloGeometry"/>
<use name="Geometry/CommonDetUnit"/>
<use name="Geometry/CommonTopologies"/>
<use name="Geometry/Records"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="Geometry/TrackerNumberingBuilder"/>
<use name="DataFormats/SiStripDetId"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="DataFormats/TrackingRecHit"/>
<use name="MagneticField/Records"/>
<use name="RecoMuon/TrackingTools"/>
<use name="RecoVertex/PrimaryVertexProducer"/>
<use name="SimDataFormats/GeneratorProducts"/>
<use name="SimDataFormats/Track"/>
<use name="SimTracker/TrackerHitAssociation"/>
<use name="TrackPropagation/SteppingHelixPropagator"/>
<use name="TrackingTools/IPTools"/>
<use name="TrackingTools/TrackAssociator"/>
<use name="TrackingTools/TrackFitters"/>
<use name="TrackingTools/TrajectoryState"/>
<use name="TrackingTools/IPTools"/>
<use name="DataFormats/TrajectorySeed"/>
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/BeamSpot"/>
<use name="RecoVertex/PrimaryVertexProducer"/>
<use name="MagneticField/Records"/>
<use name="DQMServices/Core"/>
<use name="CLHEP"/>
<use name="TrackingTools/TransientTrack"/>
<use name="root"/>
<use name="TrackingTools/TrackAssociator"/>
<use name="Geometry/CaloGeometry"/>
<use name="rootcore"/>
<use name="rootmath"/>
<use name="rootrflx"/>
<use name="rootcore"/>
<library file="*.cc" name="AlignmentOfflinevalidationPlugins">
<use name="Alignment/OfflineValidation"/>
<use name="CondFormats/GeometryObjects"/>
Expand Down
11 changes: 5 additions & 6 deletions Alignment/OfflineValidation/plugins/DMRChecker.cc
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@
#include "CommonTools/TrackerMap/interface/TrackerMap.h"
#include "CommonTools/UtilAlgos/interface/TFileService.h"
#include "CommonTools/Utils/interface/TFileDirectory.h"
#include "CondCore/SiPixelPlugins/interface/Phase1PixelMaps.h"
#include "DQM/TrackerRemapper/interface/Phase1PixelMaps.h"
#include "CondCore/SiPixelPlugins/interface/PixelRegionContainers.h"
#include "CondCore/SiPixelPlugins/interface/SiPixelPayloadInspectorHelper.h"
#include "CondFormats/DataRecord/interface/RunSummaryRcd.h"
Expand Down Expand Up @@ -98,7 +98,6 @@
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/Framework/interface/MakerMacros.h"
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
#include "FWCore/Framework/src/WorkerMaker.h"
#include "FWCore/MessageLogger/interface/ErrorObj.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
Expand Down Expand Up @@ -1676,19 +1675,19 @@ class DMRChecker : public edm::one::EDAnalyzer<edm::one::SharedResources> {
pixelmap->beautifyAllHistograms();

TCanvas cBX("CanvXBarrel", "CanvXBarrel", 1200, 1000);
pixelmap->DrawBarrelMaps("DMRsX", cBX);
pixelmap->drawBarrelMaps("DMRsX", cBX);
cBX.SaveAs("pixelBarrelDMR_x.png");

TCanvas cFX("CanvXForward", "CanvXForward", 1600, 1000);
pixelmap->DrawForwardMaps("DMRsX", cFX);
pixelmap->drawForwardMaps("DMRsX", cFX);
cFX.SaveAs("pixelForwardDMR_x.png");

TCanvas cBY("CanvYBarrel", "CanvYBarrel", 1200, 1000);
pixelmap->DrawBarrelMaps("DMRsY", cBY);
pixelmap->drawBarrelMaps("DMRsY", cBY);
cBY.SaveAs("pixelBarrelDMR_y.png");

TCanvas cFY("CanvXForward", "CanvXForward", 1600, 1000);
pixelmap->DrawForwardMaps("DMRsY", cFY);
pixelmap->drawForwardMaps("DMRsY", cFY);
cFY.SaveAs("pixelForwardDMR_y.png");
}

Expand Down
6 changes: 3 additions & 3 deletions Alignment/OfflineValidation/plugins/GeneralPurposeTrackAnalyzer.cc
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@
#include "CondFormats/AlignmentRecord/interface/GlobalPositionRcd.h"
#include "CondFormats/DataRecord/interface/SiStripCondDataRecords.h"
#include "CondFormats/SiStripObjects/interface/SiStripLatency.h"
#include "CondCore/SiPixelPlugins/interface/Phase1PixelMaps.h"
#include "DQM/TrackerRemapper/interface/Phase1PixelMaps.h"
#include "DataFormats/BeamSpot/interface/BeamSpot.h"
#include "DataFormats/Common/interface/TriggerResults.h"
#include "DataFormats/DetId/interface/DetId.h"
Expand Down Expand Up @@ -1135,11 +1135,11 @@ class GeneralPurposeTrackAnalyzer : public edm::one::EDAnalyzer<edm::one::WatchR
pixelmap->beautifyAllHistograms();

TCanvas cB("CanvBarrel", "CanvBarrel", 1200, 1000);
pixelmap->DrawBarrelMaps("entriesBarrel", cB);
pixelmap->drawBarrelMaps("entriesBarrel", cB);
cB.SaveAs("pixelBarrelEntries.png");

TCanvas cF("CanvForward", "CanvForward", 1600, 1000);
pixelmap->DrawForwardMaps("entriesForward", cF);
pixelmap->drawForwardMaps("entriesForward", cF);
cF.SaveAs("pixelForwardEntries.png");
}

Expand Down
1 change: 1 addition & 0 deletions CondCore/SiPixelPlugins/BuildFile.xml
View file
Open in desktop
@@ -1,3 +1,4 @@
<use name="CalibTracker/StandaloneTrackerTopology"/>
<use name="CalibTracker/SiPixelESProducers"/>
<use name="CondFormats/SiPixelObjects"/>
<use name="DQM/TrackerRemapper"/>