Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to D76 in HGCal geometry unit test #33326

Merged
merged 1 commit into from Apr 2, 2021

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Apr 2, 2021

PR description:

As reported in #33325, we move to D76.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no need for backporting.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33326/21875

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2021

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @ahmad3213, @civanch, @rvenditti can you please review it and eventually sign? Thanks.
@vargasa, @rovere, @apsallid, @lecriste, @rishabhCMS, @fabiocos, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Apr 2, 2021

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c4279/13966/summary.html
COMMIT: f0348b2
CMSSW: CMSSW_11_3_X_2021-04-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33326/13966/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640868
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2640845
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@silviodonato
Copy link
Contributor

merge
trivial bugfix

@cmsbuild cmsbuild merged commit 50c9d66 into cms-sw:master Apr 2, 2021
@jfernan2
Copy link
Contributor

jfernan2 commented Apr 2, 2021

+1

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 2, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants