Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Re-enable DD4hep workflow 11634.911 for PR tests #33351

Merged
merged 1 commit into from Apr 7, 2021

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Apr 6, 2021

DD4hep workflow 11634.911 was disabled for PR tests in PR #33141 because it was giving fluctuating results. Different runs of the workflow were giving one or the other of two sets of results.

After PR #33199, it appears the instability has been fixed. Repeated tests of simulation with CMSSW_11_3_X_2021-04-02-1100 and CMSSW_11_3_X_2021-04-06-1100 show consistent results (identical sequences of random seeds). It should be safe to run this workflow for PR tests.

No backport is needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33351/21933

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Apr 6, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eda90c/14041/summary.html
COMMIT: f48a05e
CMSSW: CMSSW_11_3_X_2021-04-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33351/14041/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640868
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2640833
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Apr 7, 2021

+Upgrade

This PR is to add back the DD4Hep for the short matrix test.

@chayanit
Copy link

chayanit commented Apr 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 93a7b79 into cms-sw:master Apr 7, 2021
@davidlange6
Copy link
Contributor

#33429 seems to have reproducibility issues again?

@cvuosalo
Copy link
Contributor Author

@davidlange6 Thanks for noticing. It doesn't look like #33429 PR changes geometry. I will test again to see if the instability can be reproduced.

@cvuosalo
Copy link
Contributor Author

In CMSSW_11_3_X_2021-04-15-1100 I ran DD4hep workflow 11634.911 eight times and got the same random seeds each time. It seems fairly stable.

@davidlange6
Copy link
Contributor

davidlange6 commented Apr 16, 2021 via email

@cvuosalo
Copy link
Contributor Author

@davidlange6 In some IBs a couple of months ago, the DD4hep workflow would switch back and forth randomly between two sets of random seeds almost every time it was executed, so eight consistent executions seems stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants