New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Re-enable DD4hep workflow 11634.911 for PR tests #33351
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33351/21933
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: Configuration/PyReleaseValidation @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eda90c/14041/summary.html Comparison SummarySummary:
|
+Upgrade This PR is to add back the DD4Hep for the short matrix test. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
#33429 seems to have reproducibility issues again? |
@davidlange6 Thanks for noticing. It doesn't look like #33429 PR changes geometry. I will test again to see if the instability can be reproduced. |
In CMSSW_11_3_X_2021-04-15-1100 I ran DD4hep workflow 11634.911 eight times and got the same random seeds each time. It seems fairly stable. |
Has that procedure been sufficient to reproduce problems in the past?
… On Apr 15, 2021, at 11:01 PM, Carl Vuosalo ***@***.***> wrote:
In CMSSW_11_3_X_2021-04-15-1100 I ran DD4hep workflow 11634.911 eight times and got the same random seeds each time. It seems fairly stable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@davidlange6 In some IBs a couple of months ago, the DD4hep workflow would switch back and forth randomly between two sets of random seeds almost every time it was executed, so eight consistent executions seems stable. |
DD4hep workflow 11634.911 was disabled for PR tests in PR #33141 because it was giving fluctuating results. Different runs of the workflow were giving one or the other of two sets of results.
After PR #33199, it appears the instability has been fixed. Repeated tests of simulation with CMSSW_11_3_X_2021-04-02-1100 and CMSSW_11_3_X_2021-04-06-1100 show consistent results (identical sequences of random seeds). It should be safe to run this workflow for PR tests.
No backport is needed.