Finalising esConsumes migration of HLTrigger/

[missirol]

PR description:

This PR is a follow-up of #33260, to finalise the esConsumes migration (see #31061) of HLTrigger/, based on this recent IB report (see mentions of HLTrigger/).

It requires a non-entirely-trivial update of EcalReadoutTools, for which I loosely followed part of what was done in #31892.

PR validation:

None (other than compiling).

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33362/21949

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools
HLTrigger/HLTcore
HLTrigger/special
RecoParticleFlow/PFClusterProducer

@perrotta, @malbouis, @yuanchao, @slava77, @christopheralanwest, @Martin-Grunewald, @rekovic, @cmsbuild, @tlampen, @jpata, @fwyzard, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@mmarionncern, @lecriste, @rchatter, @felicepantaleo, @cbernet, @tocheng, @lgray, @Martin-Grunewald, @rovere, @thomreis, @hatakeyamak, @simonepigazzini, @mmusich, @argiro, @seemasharmafnal, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-447f56/14075/summary.html
COMMIT: d9b5911
CMSSW: CMSSW_11_3_X_2021-04-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33362/14075/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-447f56/14075/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640868
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2640839
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[Martin-Grunewald]

+1

[slava77]

+reconstruction

for #33362 d9b5911

• code changes are in line with the PR description: EcalReadoutTools use esConsumes via EcalReadoutTools::ESGetTokens.
• jenkins tests pass and comparisons with the baseline show no (relevant) differences
  • some of CMS Clang-Tidy warnings appearing in the test summary are addressed in Migrate RecoParticleFlow/PFTracking to esConsumes #33367

[yuanchao]

+1

• WF matrix tests and unit tests passed
• CLang tidy and static build warnings (esConsumes migration) are both from PFClusterEMEnergyCorrector.cc though not the modified parts of this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1