Patatrack Shared Hit Cleaner Fix & Update #33375

VinInn · 2021-04-08T12:39:27Z

port of cms-patatrack#552

adding flag to activate the shared hit cleaning (formerly triplet cleaner) in place of minHitsPerNtuplet cut
adding minimum number of hits to allow bpix1 hit sharing (default = 3)
changing name from tripletCleaner to sharedHitCleaner

VinInn · 2021-04-08T12:41:12Z

@AdrianoDee Please check

VinInn · 2021-04-08T12:44:39Z

@cmsbuild please test

cmsbuild · 2021-04-08T12:46:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33375/21965

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): Make the the size of the binner (HistoContainer) settable at run time. The total number of Pixel Clusters is not a limit anymore on GPU #33371, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): Make the the size of the binner (HistoContainer) settable at run time. The total number of Pixel Clusters is not a limit anymore on GPU #33371, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): Make the the size of the binner (HistoContainer) settable at run time. The total number of Pixel Clusters is not a limit anymore on GPU #33371, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): Make the the size of the binner (HistoContainer) settable at run time. The total number of Pixel Clusters is not a limit anymore on GPU #33371, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): Make the the size of the binner (HistoContainer) settable at run time. The total number of Pixel Clusters is not a limit anymore on GPU #33371, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2021-04-08T12:46:25Z

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

RecoPixelVertexing/PixelTriplets

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

VinInn · 2021-04-08T12:56:44Z

@cmsbuild enable gpu

AdrianoDee · 2021-04-08T15:41:06Z

Fine by me!

cmsbuild · 2021-04-08T15:55:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea697/14104/summary.html
COMMIT: 81fbd18
CMSSW: CMSSW_11_3_X_2021-04-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33375/14104/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2865506
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2865477
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

fwyzard · 2021-04-08T16:17:42Z

assign heterogeneous

fwyzard · 2021-04-08T16:18:00Z

I'd like to run a benchmark to compare the throughput before and after.

cmsbuild · 2021-04-08T16:18:03Z

New categories assigned: heterogeneous

@makortel,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

jpata · 2021-04-09T13:57:13Z

No reco changes detected. Nothing to comment on in the code.
Let me know if there are any updates about the performance benchmark. Just to be clear, @fwyzard were you going to run it?
Thanks.

jpata · 2021-04-09T13:58:47Z

Let me know if there are any updates about the performance benchmark. Just to be clear, @fwyzard were you going to run it?

Nevermind, it was clarified in the reco meeting...

slava77 · 2021-04-09T15:48:43Z

No reco changes detected.

I don't see the GPU comparisons.
did they run?

slava77 · 2021-04-09T15:49:21Z

enable gpu

slava77 · 2021-04-09T15:49:31Z

@cmsbuild please test

cmsbuild · 2021-04-09T18:39:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea697/14144/summary.html
COMMIT: 81fbd18
CMSSW: CMSSW_11_3_X_2021-04-08-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33375/14144/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 9575
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 9575
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2865506
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2865477
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

fwyzard · 2021-04-10T07:31:17Z

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and `nvprof`/`nvvp` profiles

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
- ✔️ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
- ❌ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
- ⚠️ cuda-memcheck --tool initcheck did not run
- ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
- ⚠️ cuda-memcheck --tool synccheck did not run
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
- ✔️ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
- ✔️ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
- ❌ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
- ⚠️ cuda-memcheck --tool initcheck did not run
- ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
- ⚠️ cuda-memcheck --tool synccheck did not run
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
- ✔️ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
- ✔️ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
- ❌ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
- ⚠️ cuda-memcheck --tool initcheck did not run
- ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
- ⚠️ cuda-memcheck --tool synccheck did not run
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
- ✔️ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
- ✔️ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
- ❌ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
- ⚠️ cuda-memcheck --tool initcheck did not run
- ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
- ⚠️ cuda-memcheck --tool synccheck did not run
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
- ✔️ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
- ✔️ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
- ❌ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
- ⚠️ cuda-memcheck --tool initcheck did not run
- ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
- ⚠️ cuda-memcheck --tool synccheck did not run
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
- ✔️ step3.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
- ✔️ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
- ❌ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
- ⚠️ cuda-memcheck --tool initcheck did not run
- ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
- ⚠️ cuda-memcheck --tool synccheck did not run
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
- ✔️ step3.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
- ✔️ step3.py: log
- ✔️ profile.py: log
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
reference/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522
- ✔️ step3.py: log
- ✔️ profile.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.501
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.502
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.511
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.512
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.521
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 11634.522
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885502
- ✔️ step3.py: log
- ✔️ profile.py: log
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885512
- ❌ step3.py: log
- ❌ profile.py: log, profile and summary are missing, see the full log for more information
testing/CMSSW_11_3_X_2021-04-08-2300 release, workflow 136.885522
- ✔️ step3.py: log
- ✔️ profile.py: log

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/e3c9984e24f59f067454e9daea5bbf5bcd5d3407/log .

jpata · 2021-04-12T10:31:17Z

Thanks for the retest and performance benchmark. From what I can tell, there is no significant difference in the throughput. There are also no reco differences with the GPU test enabled.

fwyzard · 2021-04-12T10:38:05Z

Correct. We could run more tests after #31854 is merged, but I don't think that's necessary - I think we can just go ahead with this one.

fwyzard · 2021-04-12T10:38:11Z

+heterogeneous

jpata · 2021-04-12T13:55:46Z

+reconstruction

follow-up for Patatrack vertexing
technical, no observed reco changes in the GPU workflows
Patatrack benchmarks show no throughput regressions

cmsbuild · 2021-04-12T13:56:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-04-12T15:00:00Z

+1

VinInn added 2 commits April 8, 2021 14:29

import from patatrack

0c87b1d

code format

81fbd18

cmsbuild added this to the CMSSW_11_3_X milestone Apr 8, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 8, 2021

VinInn changed the title ~~Shared hit cleaner113x~~ Patatrack Shared Hit Cleaner Fix & Update Apr 8, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 8, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 8, 2021

cmsbuild added the heterogeneous-pending label Apr 8, 2021

cmsbuild added tests-started and removed tests-approved labels Apr 9, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 9, 2021

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Apr 12, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Apr 12, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 12, 2021

cmsbuild merged commit 1f40484 into cms-sw:master Apr 12, 2021

cmsbuild mentioned this pull request Apr 12, 2021

Make the the size of the binner (HistoContainer) settable at run time. The total number of Pixel Clusters is not a limit anymore on GPU #33371

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patatrack Shared Hit Cleaner Fix & Update #33375

Patatrack Shared Hit Cleaner Fix & Update #33375

VinInn commented Apr 8, 2021 •

edited

VinInn commented Apr 8, 2021

VinInn commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

VinInn commented Apr 8, 2021

AdrianoDee commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

fwyzard commented Apr 8, 2021

fwyzard commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

jpata commented Apr 9, 2021

jpata commented Apr 9, 2021

slava77 commented Apr 9, 2021

slava77 commented Apr 9, 2021

slava77 commented Apr 9, 2021

cmsbuild commented Apr 9, 2021

fwyzard commented Apr 10, 2021

jpata commented Apr 12, 2021

fwyzard commented Apr 12, 2021

fwyzard commented Apr 12, 2021

jpata commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

silviodonato commented Apr 12, 2021

Patatrack Shared Hit Cleaner Fix & Update #33375

Patatrack Shared Hit Cleaner Fix & Update #33375

Conversation

VinInn commented Apr 8, 2021 • edited

VinInn commented Apr 8, 2021

VinInn commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

VinInn commented Apr 8, 2021

AdrianoDee commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

Comparison Summary

fwyzard commented Apr 8, 2021

fwyzard commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

jpata commented Apr 9, 2021

jpata commented Apr 9, 2021

slava77 commented Apr 9, 2021

slava77 commented Apr 9, 2021

slava77 commented Apr 9, 2021

cmsbuild commented Apr 9, 2021

GPU Comparison Summary

Comparison Summary

fwyzard commented Apr 10, 2021

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

Logs

jpata commented Apr 12, 2021

fwyzard commented Apr 12, 2021

fwyzard commented Apr 12, 2021

jpata commented Apr 12, 2021

cmsbuild commented Apr 12, 2021

silviodonato commented Apr 12, 2021

VinInn commented Apr 8, 2021 •

edited

logs and `nvprof`/`nvvp` profiles