Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSCShowerDigi data format (HadronicShowerTrigger-1) #33389

Merged
merged 1 commit into from
Apr 13, 2021
Merged

CSCShowerDigi data format (HadronicShowerTrigger-1) #33389

merged 1 commit into from
Apr 13, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 9, 2021

PR description:

This is the first PR (of several) to integrate the emulator of the new hadronic shower trigger in Run-3. Each CSC chamber will send 4 bits per bunch crossing to the Muon Port Card, and to the Muon Track Finder Sector Processors. These bits are called TMBi\_HMT[3:0] for each MPC. In the simulation, they are contained in the new CSCShowerDigi data format. Two bits are allocated for in-time; two bits for out-of-time. Documentation can be found here: DN-20-033.

Screen Shot 2021-04-09 at 2 04 03 PM

PR validation:

Code compiles. Tested with WF 11634.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A. We expect the (local trigger, track-finder, uGMT) firmware to be available by Summer 2021. I'll first develop the entire emulator in 11_3_X, then backport if need be.

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33389/22005

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Apr 11, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03a856/14162/summary.html
COMMIT: de1c9b0
CMSSW: CMSSW_11_3_X_2021-04-11-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33389/14162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2865477
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 12, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 13, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants