Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More BuildFiles cleaning #33445

Merged
merged 1 commit into from Apr 17, 2021
Merged

More BuildFiles cleaning #33445

merged 1 commit into from Apr 17, 2021

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #33282).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 11_3_0_pre6.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33445/22130

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Alignment/LaserAlignmentSimulation
CUDADataFormats/HGCal
DQM/TrackerRemapper
RecoLocalCalo/HGCalRecProducers
RecoLocalFastTime/FTLCommonAlgos
RecoMTD/DetLayers
RecoTracker/TkSeedGenerator
SimCalorimetry/EcalEBTrigPrimAlgos
SimDataFormats/Associations
Validation/HGCalValidation

@andrius-k, @kpedro88, @rekovic, @tlampen, @pohsun, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @fwyzard, @mdhildreth, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @kmaeshima, @christopheralanwest, @srimanob, @rvenditti can you please review it and eventually sign? Thanks.
@felicepantaleo, @hatakeyamak, @argiro, @bsunanda, @pfs, @thomreis, @lgray, @threus, @mmusich, @hdelanno, @makortel, @JanFSchulte, @dgulhan, @apsallid, @simonepigazzini, @vandreev11, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @tocheng, @jandrea, @idebruyn, @ebrondol, @mtosi, @fabiocos, @clelange, @sethzenz, @adewit, @rchatter, @edjtscott, @lecriste, @gpetruc, @fioriNTU this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-632e1d/14261/summary.html
COMMIT: f24c2ac
CMSSW: CMSSW_11_3_X_2021-04-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33445/14261/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2864426
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2864397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@yuanchao
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor

+1

@makortel
Copy link
Contributor

+heterogeneous

@srimanob
Copy link
Contributor

+Upgrade

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@civanch
Copy link
Contributor

civanch commented Apr 16, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 17, 2021

+1

@cmsbuild cmsbuild merged commit 0813868 into cms-sw:master Apr 17, 2021
@guitargeek guitargeek deleted the deps_1 branch April 18, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants