Speedup Track Validation

[VinInn]

Few technical changes to speed up Track Validation.
More can be done (see old comments in the code for instance)

before
http://innocent.web.cern.ch/innocent/perfResults/igprof-navigator/gpuDQMDebug_ori_CMSSW_12_0_X_2021-04-18-0000_slc7_amd64_gcc900/37
after
http://innocent.web.cern.ch/innocent/perfResults/igprof-navigator/gpuDQMDebug_speed_CMSSW_12_0_X_2021-04-18-0000_slc7_amd64_gcc900/48

Purely technical, no regression expected.

[VinInn]

@cmsbuild please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33462/22160

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33462/22160/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33462/22160/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[VinInn]

To github.com:VinInn/cmssw.git
   6044c2ed2d6..df1b08626db  HEAD -> SpeedupMTV
[innocent@patatrack02 src]$ git diff
[innocent@patatrack02 src]$ scram b code-format
>> Local Products Rules ..... started
>> Local Products Rules ..... done
gmake[1]: Entering directory '/home/innocent/SpeedUpMTV/CMSSW_12_0_X_2021-04-18-0000'
>> Local Products Rules ..... started
>> Local Products Rules ..... done
gmake[1]: Leaving directory '/home/innocent/SpeedUpMTV/CMSSW_12_0_X_2021-04-18-0000'
[innocent@patatrack02 src]$ git diff
[innocent@patatrack02 src]$

[VinInn]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33462/22161

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

SimGeneral/TrackingAnalysis
SimTracker/TrackAssociation
SimTracker/TrackerHitAssociation
Validation/RecoTrack

@civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @fabiocos, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @Fedespring, @jhgoh, @calderona, @cericeci, @HuguesBrun, @rovere, @threus, @wmtford, @mtosi, @ebrondol, @trocino, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0573f7/14311/summary.html
COMMIT: c7c1668
CMSSW: CMSSW_12_0_X_2021-04-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33462/14311/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0573f7/14311/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 32414
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2844610
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33462/22240

• This PR adds an extra 92KB to repository

• Found files with invalid states:

  • SimGeneral/TrackingAnalysis/interface/SimHitTPAssociationProducer.h:
    • Deleted: b94fb38
    • Added: 1f5f009

[cmsbuild]

Pull request #33462 was updated. @civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please check and sign again.

[VinInn]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0573f7/14414/summary.html
COMMIT: 44e08c9
CMSSW: CMSSW_12_0_X_2021-04-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33462/14414/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0573f7/14414/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877023
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1