Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[106X] Add ParticleNet mass regression #33588

Merged

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 30, 2021

PR description:

Backport of #33483 for NanoAODv9.
Changes w.r.t #33483 for NanoAODv9 are made to respect the no-change policy for MiniAOD and NanoAOD v8.

Requires: cms-data/RecoBTag-Combined#44 (DNN model)
Requires: cms-data/RecoBTag-Combined#45 (DNN model)

PR validation:

Tested w/ NanoAOD workflows 1325.81 (no change) and 136.8523 (the new FatJet_particleNet_mass is added).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
RecoBTag/ONNXRuntime

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @swertz, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented May 3, 2021

test parameters:

@jpata
Copy link
Contributor

jpata commented May 3, 2021

@cmsbuild please test

@jpata
Copy link
Contributor

jpata commented May 3, 2021

@hqucms

In 10_6_X, RecoBTag/Combined is on V01-07-01: https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X%2Fgcc820/data/cmsswdata.txt#L10

Therefore, cms-data/RecoBTag-Combined#44 must also be backported against the branch
https://github.com/cms-data/RecoBTag-Combined/tree/CMSSW_10_6_X (V01-07-01 + diffs from cms-data/RecoBTag-Combined#44), so that the data tag can be updated in cms-sw/cmssw/10_6_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d796f/14797/summary.html
COMMIT: 6035382
CMSSW: CMSSW_10_6_X_2021-05-03-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

----- Begin Fatal Exception 03-May-2021 13:34:17 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK8/MassRegression/V01/particle-net.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2


At:
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Types.py(639): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(356): insertContentsInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(482): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Modules.py(162): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(900): _insertManyInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(1102): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 03-May-2021 14:04:27 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step6_NANO.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK8/MassRegression/V01/particle-net.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14797/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018


At:
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Types.py(639): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(356): insertContentsInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(482): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Modules.py(162): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(900): _insertManyInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(1102): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
  • 136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log
  • 136.8523136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2/step2_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2.log
Expand to see more relval errors ...

@hqucms
Copy link
Contributor Author

hqucms commented May 3, 2021

@hqucms

In 10_6_X, RecoBTag/Combined is on V01-07-01: https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X%2Fgcc820/data/cmsswdata.txt#L10

Therefore, cms-data/RecoBTag-Combined#44 must also be backported against the branch
https://github.com/cms-data/RecoBTag-Combined/tree/CMSSW_10_6_X (V01-07-01 + diffs from cms-data/RecoBTag-Combined#44), so that the data tag can be updated in cms-sw/cmssw/10_6_X.

@jpata OK I see:) I just made another PR for 10_6_X: cms-data/RecoBTag-Combined#45

@jpata
Copy link
Contributor

jpata commented May 3, 2021

test parameters:

@jpata
Copy link
Contributor

jpata commented May 3, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d796f/14802/summary.html
COMMIT: 6035382
CMSSW: CMSSW_10_6_X_2021-05-03-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

----- Begin Fatal Exception 03-May-2021 15:45:20 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK8/MassRegression/V01/particle-net.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2


At:
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Types.py(639): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(356): insertContentsInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(482): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Modules.py(162): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(900): _insertManyInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(1102): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 03-May-2021 16:15:10 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step6_NANO.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK8/MassRegression/V01/particle-net.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14802/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/poison:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018


At:
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Types.py(639): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(356): insertContentsInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Mixins.py(482): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Modules.py(162): insertInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(900): _insertManyInto
  /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-03-1100/python/FWCore/ParameterSet/Config.py(1102): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
  • 136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log
  • 136.8523136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2/step2_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2.log
Expand to see more relval errors ...

@hqucms
Copy link
Contributor Author

hqucms commented May 3, 2021

@jpata It seems the cms-data PR is not included in the test?

@jpata
Copy link
Contributor

jpata commented May 4, 2021

weird, I'm not sure why the data PR was not accepted properly?

@hqucms
Copy link
Contributor Author

hqucms commented May 4, 2021

test parameters:

Should it be pull_request = ...?

@jpata
Copy link
Contributor

jpata commented May 4, 2021

Should it be pull_request = ...?

According to http://cms-sw.github.io/cms-bot-cmssw-cmds.html, the thumbs up from the bot (and past experience), it's fine.
On the other hand, looking at the PR checks "test_parameters", there's something confusing:

831256303:ERRORS: format:'pull_requests: cms-data/RecoBTag-Comb

and this cannot be expanded to look at further details.

@smuzaffar could you help us dig into details here?

@smuzaffar
Copy link
Contributor

@jpata , it should be with = , I will check why bot did a thumbs up but added an error in the status

@smuzaffar
Copy link
Contributor

smuzaffar commented May 4, 2021

test parameters:

@smuzaffar
Copy link
Contributor

please test

bot now properly thumbs down if test parameter is wrong

@jpata
Copy link
Contributor

jpata commented May 4, 2021

I see, it was : vs =, not pull_request vs pull_requests. This often trips me up. Thanks for checking!

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d796f/14839/summary.html
COMMIT: 6035382
CMSSW: CMSSW_10_6_X_2021-05-04-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33588/14839/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215556
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215221
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.208 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 136.8523 ): 0.208 KiB Physics/NanoAODDQM
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented May 6, 2021

Code changes look OK to me, as far as I can see, the new feature is protected by run2_miniAOD_devel and run2_nanoAOD_devel as required.

The changes only appear in the workflows 10824.0 and 136.8523 - as far as I can tell this is expected, since they are the 2018 development workflows.

Waiting for cms-sw/cmsdist#6881 to be merged before proceeding.

@jpata
Copy link
Contributor

jpata commented May 10, 2021

+reconstruction

@qliphy
Copy link
Contributor

qliphy commented May 11, 2021

cms-sw/cmsdist#6881 is now merged

@mariadalfonso
Copy link
Contributor

+xpog

changes inline with master, verified no change in run2_nanoAOD_106Xv1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 12, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants