New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[106X] Add ParticleNet mass regression #33588
[106X] Add ParticleNet mass regression #33588
Conversation
A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X. It involves the following packages: PhysicsTools/NanoAOD @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
@cmsbuild please test |
In 10_6_X, RecoBTag/Combined is on V01-07-01: https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X%2Fgcc820/data/cmsswdata.txt#L10 Therefore, cms-data/RecoBTag-Combined#44 must also be backported against the branch |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsNanoAOD had ERRORS RelVals
RelVals-INPUT
|
@jpata OK I see:) I just made another PR for 10_6_X: cms-data/RecoBTag-Combined#45 |
test parameters: |
@cmsbuild please test |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsNanoAOD had ERRORS RelVals
RelVals-INPUT
|
@jpata It seems the cms-data PR is not included in the test? |
weird, I'm not sure why the data PR was not accepted properly? |
Should it be |
According to http://cms-sw.github.io/cms-bot-cmssw-cmds.html, the thumbs up from the bot (and past experience), it's fine. 831256303:ERRORS: format:'pull_requests: cms-data/RecoBTag-Comb and this cannot be expanded to look at further details. @smuzaffar could you help us dig into details here? |
@jpata , it should be with |
test parameters: |
please test bot now properly thumbs down if test parameter is wrong |
I see, it was |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d796f/14839/summary.html Comparison SummarySummary:
|
Code changes look OK to me, as far as I can see, the new feature is protected by The changes only appear in the workflows 10824.0 and 136.8523 - as far as I can tell this is expected, since they are the 2018 development workflows. Waiting for cms-sw/cmsdist#6881 to be merged before proceeding. |
+reconstruction
|
cms-sw/cmsdist#6881 is now merged |
+xpog changes inline with master, verified no change in run2_nanoAOD_106Xv1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #33483 for NanoAODv9.
Changes w.r.t #33483 for NanoAODv9 are made to respect the no-change policy for MiniAOD and NanoAOD v8.
Requires: cms-data/RecoBTag-Combined#44 (DNN model)Requires: cms-data/RecoBTag-Combined#45 (DNN model)
PR validation:
Tested w/ NanoAOD workflows 1325.81 (no change) and 136.8523 (the new
FatJet_particleNet_mass
is added).