Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

dildick · 2021-05-04T02:39:32Z

PR description:

More prep work for the Run-3 GEM-CSC integrated local trigger. This goes together with PR cms-data/L1Trigger-CSCTriggerPrimitives#6. Follow-up of #33570

Quality assignment functions were moved to LCTQualityAssignment
GEMCSC LUT producer was updated to reflect Update of ME1/1 LUTs. GEM-CSC LUTs with M9 GE2/1 geometry cms-data/L1Trigger-CSCTriggerPrimitives#6
LUT functions for physical ALCT-CLCT crossings were moved to CSCALCTCrossCLCT
New procedures for Run-3 GEM-CSC trigger were added

In the next PR we will be updating the GEM-CSC matching procedures with 1/2-strip resolution and 1/8-strip resolution. The former is intended to be compatible with Run-2 EMTF. The latter would be compatible with Run-3 EMTF. The CSCUpgradeMotherboardLUT will be deleted (all luts in cms-data). CSCGEMMotherboardME11 and CSCGEMMotherboardME21 will be merged into CSCGEMMotherboard. CSCMotherboardME11 will be merged into CSCUpgradeMotherboard. This will be possible since we don't split up the LCT finding in ME1/a and ME1/b. Sorting and readout functions will be streamlined as well.

PR validation:

Tested with WF 11634.0. There shouldn't be any changes in WFs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@tahuang1991

dildick · 2021-05-04T02:40:06Z

Needs to be tested with cms-data/L1Trigger-CSCTriggerPrimitives#6

cmsbuild · 2021-05-04T02:45:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33617/22461

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/plugins/GEMCSCLUTAnalyzer.cc modified in PR(s): Cleanup of data/simulation analyzer modules in CSCTriggerPrimitives #33582
- File L1Trigger/CSCTriggerPrimitives/test/BuildFile.xml modified in PR(s): Cleanup of data/simulation analyzer modules in CSCTriggerPrimitives #33582

cmsbuild · 2021-05-04T02:45:57Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2021-05-04T06:41:05Z

please test with cms-data/L1Trigger-CSCTriggerPrimitives#6

cmsbuild · 2021-05-04T13:20:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f787e7/14827/summary.html
COMMIT: 8bf4688
CMSSW: CMSSW_12_0_X_2021-05-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662646
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2662617
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-05-04T17:48:45Z

Pull request #33617 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

cecilecaillol · 2021-05-05T07:00:05Z

please test

cmsbuild · 2021-05-05T08:10:10Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f787e7/14867/summary.html
COMMIT: af1c886
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

312.0

----- Begin Fatal Exception 05-May-2021 09:25:52 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/ME11/CSCLUT_wg_min_hs_ME1a.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO
----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 05-May-2021 09:36:43 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/ME11/CSCLUT_wg_min_hs_ME1a.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 05-May-2021 09:36:50 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/ME11/CSCLUT_wg_min_hs_ME1a.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/12434.0_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

138.1138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3/step2_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3.log
138.2138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

AddOn Tests

hlt_data_PRef

----- Begin Fatal Exception 05-May-2021 09:18:36 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/ME11/CSCLUT_wg_min_hs_ME1a.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14867/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-04-2300/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_data_PRef
----- End Fatal Exception -------------------------------------------------

hlt_mc_PRef

----- Begin Fatal Exception 05-May-2021 09:19:15 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

hlt_data_PRef

----- Begin Fatal Exception 05-May-2021 09:19:35 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_DATA.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_DATA.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

dildick · 2021-05-05T12:07:15Z

Hi @cecilecaillol. Thanks for running the tests. Could retry with please test with cms-data/L1Trigger-CSCTriggerPrimitives#6? That seemed to work the first time.

cecilecaillol · 2021-05-05T12:09:29Z

please test with cms-data/L1Trigger-CSCTriggerPrimitives#6

cmsbuild · 2021-05-05T22:41:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f787e7/14882/summary.html
COMMIT: af1c886
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33617/14882/install.sh to create a dev area with all the needed externals and cmssw changes.

Found compilation warnings

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662646
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2662611
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

dildick · 2021-05-05T23:01:01Z

11 failures from messagelogger, 1 from pixel

cecilecaillol · 2021-05-07T07:21:54Z

+l1

cmsbuild · 2021-05-07T07:22:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-05-07T12:26:57Z

+1

dildick · 2021-05-07T16:44:34Z

Thanks @cecilecaillol.

Sven Dildick added 10 commits May 3, 2021 15:31

use quality assignment

87f95fe

GEM-CSC luts based on D80

9294258

Use quality functions in LCTQualityAssignment

0cba446

Code format

110e042

Use LUTs and CSCALCTCrossCLCT helper class

33e224d

Bugfix: region should be int

f0cdbcd

New procedures for Run-3 GEM-CSC trigger

d6987a5

Code format

baa05f8

Move to processor

ec8acb5

Bugfix

8bf4688

cmsbuild added this to the CMSSW_12_0_X milestone May 4, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels May 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 4, 2021

smuzaffar mentioned this pull request May 4, 2021

Update of ME1/1 LUTs. GEM-CSC LUTs with M9 GE2/1 geometry cms-data/L1Trigger-CSCTriggerPrimitives#6

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels May 4, 2021

smuzaffar mentioned this pull request May 4, 2021

Update tag for L1Trigger-CSCTriggerPrimitives to V00-06-00 cms-sw/cmsdist#6872

Merged

cmsbuild added tests-approved and removed tests-started labels May 4, 2021

cmsbuild added tests-started and removed tests-pending labels May 5, 2021

cmsbuild added tests-rejected and removed tests-started labels May 5, 2021

cmsbuild added requires-external tests-started and removed tests-rejected labels May 5, 2021

cmsbuild added tests-approved and removed tests-started labels May 5, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 7, 2021

cmsbuild added orp-approved and removed orp-pending labels May 7, 2021

cmsbuild merged commit a69f7b8 into cms-sw:master May 7, 2021

dildick deleted the from-CMSSW_12_0_X_2021-05-03-1100-GEMCSC-Run3-prep-2 branch May 7, 2021 12:45

dildick changed the title ~~More prep work for the Run-3 GEM-CSC integrated local trigger~~ Prep work for the Run-3 GEM-CSC integrated local trigger (II) Jun 4, 2021

dildick mentioned this pull request Jun 4, 2021

Prep work for the Run-3 GEM-CSC integrated local trigger (III) #33974

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

dildick commented May 4, 2021 •

edited

dildick commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

smuzaffar commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

cecilecaillol commented May 5, 2021

cmsbuild commented May 5, 2021

dildick commented May 5, 2021

cecilecaillol commented May 5, 2021

cmsbuild commented May 5, 2021

dildick commented May 5, 2021

cecilecaillol commented May 7, 2021

cmsbuild commented May 7, 2021

qliphy commented May 7, 2021

dildick commented May 7, 2021

Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

Prep work for the Run-3 GEM-CSC integrated local trigger (II) #33617

Conversation

dildick commented May 4, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

dildick commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

smuzaffar commented May 4, 2021

cmsbuild commented May 4, 2021

Comparison Summary

cmsbuild commented May 4, 2021

cecilecaillol commented May 5, 2021

cmsbuild commented May 5, 2021

RelVals

RelVals-INPUT

AddOn Tests

dildick commented May 5, 2021

cecilecaillol commented May 5, 2021

cmsbuild commented May 5, 2021

Comparison Summary

dildick commented May 5, 2021

cecilecaillol commented May 7, 2021

cmsbuild commented May 7, 2021

qliphy commented May 7, 2021

dildick commented May 7, 2021

dildick commented May 4, 2021 •

edited