Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test in PhysicsTools/UtilAlgos (11_2_X) #33640

Merged
merged 1 commit into from
May 6, 2021

Conversation

qliphy
Copy link
Contributor

@qliphy qliphy commented May 6, 2021

PR description:

This PR fixes a unit test failure due to a missing input file.

PR validation:

FWLiteWithBasicAnalyzer fwliteWithPythonConfig_cfg.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33464

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone May 6, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

A new Pull Request was created by @qliphy (Qiang Li) for CMSSW_11_2_X.

It involves the following packages:

PhysicsTools/UtilAlgos

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor Author

qliphy commented May 6, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5c80f/14896/summary.html
COMMIT: bac55f7
CMSSW: CMSSW_11_2_X_2021-05-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33640/14896/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2537235
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2537206
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor Author

qliphy commented May 6, 2021

merge

@cmsbuild cmsbuild merged commit 2af020c into cms-sw:CMSSW_11_2_X May 6, 2021
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants