Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackDistanceValueMapProducer: check the size of the reference vector before copying #33648

Merged
merged 1 commit into from
May 11, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 6, 2021

resolves #33533 (?)

PR description:

See #33533 (comment)
Suggested by core framework group.

PR validation:

Compiles, not validated on the PPC architecture, as I don't know how to do that. I let the framework people deal with it.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@mmusich
Copy link
Contributor Author

mmusich commented May 6, 2021

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33648/22524

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33648/22526

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 6, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-732450/14913/summary.html
COMMIT: f01d86f
CMSSW: CMSSW_12_0_X_2021-05-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33648/14913/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2662617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33648/22550

ERROR: Build errors found during clang-tidy run.

Calibration/TkAlCaRecoProducers/plugins/TrackDistanceValueMapProducer.cc:123:30: error: no matching function for call to 'min' [clang-diagnostic-error]
    std::copy(v_dR2.begin(), std::min(v_dR2.size(), v_dR2.begin() + nthClosestTrack_), std::back_inserter(reduced_vdR2));
                             ^
/cvmfs/cms-ib.cern.ch/nweek-02679/slc7_amd64_gcc900/external/gcc/9.3.0/lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../include/c++/9.3.0/bits/algorithmfwd.h:383:5: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long' vs. '__gnu_cxx::__normal_iterator<float *, std::vector<float, std::allocator<float>>>')
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33648/22553

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

Pull request #33648 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-732450/14942/summary.html
COMMIT: 9329fb3
CMSSW: CMSSW_12_0_X_2021-05-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33648/14942/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2662617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented May 11, 2021

kindly ping @cms-sw/alca-l2

@francescobrivio
Copy link
Contributor

+alca

  • bugfix
  • tests passed (failure only related to the MessageLogger)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 11, 2021

+1

@cmsbuild cmsbuild merged commit 923645e into cms-sw:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PPC] Segfault in TrackDistanceValueMapProducer
5 participants