Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary static variable declaration from CaloTauSelectorDefinition #3374

Merged

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer flagged the static as a thread safety issue. Turns out
a local variable is actually what should have been intended.

…efinition

The static analyzer flagged the static as a thread safety issue. Turns out
a local variable is actually what should have been intended.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Removed unnecessary static variable declaration from CaloTauSelectorDefinition

It involves the following packages:

RecoTauTag/TauTagTools

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 18, 2014

+1

for #3374 f25c680
trivial

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 19, 2014
…orDefinition

Multithreading -- Removed unnecessary static variable declaration from CaloTauSelectorDefinition
@ktf ktf merged commit e51f7ea into cms-sw:CMSSW_7_1_X Apr 19, 2014
@Dr15Jones Dr15Jones deleted the removeStaticFromCaloTauSelectorDefinition branch April 23, 2014 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants