Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11_3_X] fixed esConsumes call in L1TriggerJSONMonitoring #33814

Conversation

missirol
Copy link
Contributor

PR description:

Backport of #33809

Description from the original PR below:


Fix for a bug introduced in #33260: the module L1TriggerJSONMonitoring is now migrated correctly to esConsumes.

Spotted by TSG's FOG group during HLT-validation tests for the next MWGR.

Attn: @Sam-Harper @mzarucki @gennai


PR validation:

Reproduced the issue seen by FOG, and verified that this update solves it.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#33809

Backport needed for the next MWGR.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_11_3_X.

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ecc6a/15246/summary.html
COMMIT: 4d4992d
CMSSW: CMSSW_11_3_X_2021-05-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33814/15246/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3033 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 7778
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2869246
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 1 / 37 workflows

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 22, 2021

+1

@cmsbuild cmsbuild merged commit e1cf57e into cms-sw:CMSSW_11_3_X May 22, 2021
@missirol missirol deleted the devel_fixESConsumesL1TriggerJSONMonitoring_1130 branch March 27, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants